]> granicus.if.org Git - python/commitdiff
Prefer assertEqual to simply assert per recommendation in issue6727.
authorJason R. Coombs <jaraco@jaraco.com>
Wed, 20 Jun 2012 14:24:24 +0000 (10:24 -0400)
committerJason R. Coombs <jaraco@jaraco.com>
Wed, 20 Jun 2012 14:24:24 +0000 (10:24 -0400)
Clarified comment on disabled code to reference issue15093.

Lib/test/test_import.py

index 7ae690bbdeb1c3872622f246a8632aecdc7afdc4..c94d7bd553cd564812e926abada9c855cf8b3d36 100644 (file)
@@ -707,14 +707,19 @@ class TestSymbolicallyLinkedPackage(unittest.TestCase):
         os.mkdir(self.tagged)
         init_file = os.path.join(self.tagged, '__init__.py')
         open(init_file, 'w').close()
-        assert os.path.exists(init_file)
+        self.assertEqual(os.path.exists(init_file), True)
 
         # now create a symlink to the tagged package
         # sample -> sample-tagged
         os.symlink(self.tagged, self.package_name)
 
-        # assert os.path.isdir(self.package_name) # currently fails
-        assert os.path.isfile(os.path.join(self.package_name, '__init__.py'))
+        # disabled because os.isdir currently fails (see issue 15093)
+        # self.assertEqual(os.path.isdir(self.package_name), True)
+
+        self.assertEqual(
+            os.path.isfile(os.path.join(self.package_name, '__init__.py')),
+            True,
+        )
 
     @property
     def tagged(self):