]> granicus.if.org Git - clang/commitdiff
In ExprEvaluatorBase::VisitOpaqueValueExpr() add a sanity check to avoid
authorArgyrios Kyrtzidis <akyrtzi@gmail.com>
Fri, 9 Dec 2011 02:44:48 +0000 (02:44 +0000)
committerArgyrios Kyrtzidis <akyrtzi@gmail.com>
Fri, 9 Dec 2011 02:44:48 +0000 (02:44 +0000)
infinite recursion due to bad OpaqueValueExpr.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@146237 91177308-0d34-0410-b5e6-96231b3b80d8

lib/AST/ExprConstant.cpp

index cbb75db25577059ef46f3df9901402c8a3f2ce11..c095f2166d65391b5ce04e499cd3073dc314eaeb 100644 (file)
@@ -1557,9 +1557,16 @@ public:
 
   RetTy VisitOpaqueValueExpr(const OpaqueValueExpr *E) {
     const CCValue *Value = Info.getOpaqueValue(E);
-    if (!Value)
-      return (E->getSourceExpr() ? StmtVisitorTy::Visit(E->getSourceExpr())
-                                 : DerivedError(E));
+    if (!Value) {
+      const Expr *Source = E->getSourceExpr();
+      if (!Source)
+        return DerivedError(E);
+      if (Source == E) { // sanity checking.
+        assert(0 && "OpaqueValueExpr recursively refers to itself");
+        return DerivedError(E);
+      }
+      return StmtVisitorTy::Visit(Source);
+    }
     return DerivedSuccess(*Value, E);
   }