#3614: Correct a typo in xmlrpc.client.

diff --git a/Lib/xmlrpc/client.py b/Lib/xmlrpc/client.py
index 121fedf7f08e5bd669f8829a85e76794a6c10411..d18efce4c101aa856c6b3cdec23891c9d52b6b41 100644 (file)
--- a/Lib/xmlrpc/client.py
+++ b/Lib/xmlrpc/client.py
@@ -1203,7 +1203,7 @@ class Transport:
         headers = {}
         if extra_headers:
             for key, val in extra_headers:
-                header[key] = val
+                headers[key] = val
         headers["Content-Type"] = "text/xml"
         headers["User-Agent"] = self.user_agent
         connection.request("POST", handler, request_body, headers)
@@ -1271,7 +1271,7 @@ class SafeTransport(Transport):
         headers = {}
         if extra_headers:
             for key, val in extra_headers:
-                header[key] = val
+                headers[key] = val
         headers["Content-Type"] = "text/xml"
         headers["User-Agent"] = self.user_agent
         connection.request("POST", handler, request_body, headers)

diff --git a/Misc/NEWS b/Misc/NEWS
index 3d10f6ee55cac8927e11f0d4998b9c17c970f0ca..9c521f226ee3ae8ad6f1fa8c4b1d9487e7c49dc9 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -46,6 +46,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #3614: Corrected a typo in xmlrpc.client, leading to a NameError
+  "global name 'header' is not defined".
+
 - Issue #2834: update the regular expression library to match the unicode
   standards of py3k. In other words, mixing bytes and unicode strings
   (be it as pattern, search string or replacement string) raises a TypeError.