]> granicus.if.org Git - clang/commitdiff
Sema/transparent_union: Make sure to add implicit cast when constructing
authorDaniel Dunbar <daniel@zuster.org>
Fri, 17 Sep 2010 23:21:43 +0000 (23:21 +0000)
committerDaniel Dunbar <daniel@zuster.org>
Fri, 17 Sep 2010 23:21:43 +0000 (23:21 +0000)
implicit union values for the transparent_union extension.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@114236 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaExpr.cpp
test/CodeGen/transparent-union.c [new file with mode: 0644]

index 83319a8087877d4f987bbf7e42f4a3bd60711c50..c65db7e835edcc6636253fd39e0df74ef1aa49c8 100644 (file)
@@ -4954,6 +4954,7 @@ Sema::CheckTransparentUnionArgumentConstraints(QualType ArgType, Expr *&rExpr) {
 
     if (CheckAssignmentConstraints(it->getType(), rExpr->getType())
           == Compatible) {
+      ImpCastExprToType(rExpr, it->getType(), CK_Unknown);
       InitField = *it;
       break;
     }
diff --git a/test/CodeGen/transparent-union.c b/test/CodeGen/transparent-union.c
new file mode 100644 (file)
index 0000000..9f1cdda
--- /dev/null
@@ -0,0 +1,22 @@
+// RUN: %clang_cc1 -triple i386-unknown-unknown -emit-llvm -o %t %s
+// RUN: FileCheck < %t %s
+//
+// FIXME: Note that we don't currently get the ABI right here. f0() should be
+// f0(i8*).
+
+typedef union {
+  void *f0;
+} transp_t0 __attribute__((transparent_union));
+
+void f0(transp_t0 obj);
+
+// CHECK: define void @f1_0(i32* %a0) 
+// CHECK:  call void @f0(%union.anon* byval %{{.*}})
+// CHECK: }
+void f1_0(int *a0) {
+  f0(a0);
+}
+
+void f1_1(int *a0) {
+  f0((transp_t0) { a0 });
+}