]> granicus.if.org Git - libtirpc/commitdiff
Do not skip records with nonblocking connections
authorSteve Dickson <steved@redhat.com>
Sat, 18 Jun 2011 13:49:40 +0000 (09:49 -0400)
committerSteve Dickson <steved@redhat.com>
Tue, 21 Jun 2011 18:31:44 +0000 (14:31 -0400)
With non-blocking connections, do not skip records when receiving
the streams since entire value messages can be ignored which
in cause the entire stream to become out of sync.

For example, two mounts simultaneously send two unmaps
commands. The first one is read, then the second thrown
away due to skipping the record. Skipping this record
will cause XDR error later in processing of the stream.

Signed-off-by: Steve Dickson <steved@redhat.com>
src/svc_vc.c

index aaaf2d771b01f713e5966b7f661650d0aa7b43d1..87406f1c188df2cc617a91ad9b54ba1c0c2b6a2d 100644 (file)
@@ -610,7 +610,11 @@ svc_vc_recv(xprt, msg)
        }
 
        xdrs->x_op = XDR_DECODE;
-       (void)xdrrec_skiprecord(xdrs);
+       /*
+        * No need skip records with nonblocking connections
+        */
+       if (cd->nonblock == FALSE)
+               (void)xdrrec_skiprecord(xdrs);
        if (xdr_callmsg(xdrs, msg)) {
                cd->x_id = msg->rm_xid;
                return (TRUE);