]> granicus.if.org Git - python/commitdiff
closes bpo-35184: Fix XML_POOR_ENTROPY option that breaks makesetup parsing of pyexpa...
authoraaronpaulhurst <aaronpaulhurst@gmail.com>
Tue, 11 Jun 2019 01:54:24 +0000 (18:54 -0700)
committerBenjamin Peterson <benjamin@python.org>
Tue, 11 Jun 2019 01:54:24 +0000 (18:54 -0700)
When the line is uncommented, the equals character causes it to be incorrectly interpreted
as a macro definition by makesetup.  This results in invalid Makefile output.

The expat code only requires XML_POOR_ENTROPY to be defined; the value is unnecessary.

Modules/Setup

index e729ab883f410b17e50e45ba2511fba8db68d153..ed5ee6c5033b5b8c956b917f0b02b784d71b8eca 100644 (file)
@@ -338,7 +338,7 @@ _symtable symtablemodule.c
 # Interface to the Expat XML parser
 # More information on Expat can be found at www.libexpat.org.
 #
-#pyexpat expat/xmlparse.c expat/xmlrole.c expat/xmltok.c pyexpat.c -I$(srcdir)/Modules/expat -DHAVE_EXPAT_CONFIG_H -DXML_POOR_ENTROPY=1 -DUSE_PYEXPAT_CAPI
+#pyexpat expat/xmlparse.c expat/xmlrole.c expat/xmltok.c pyexpat.c -I$(srcdir)/Modules/expat -DHAVE_EXPAT_CONFIG_H -DXML_POOR_ENTROPY -DUSE_PYEXPAT_CAPI
 
 # Hye-Shik Chang's CJKCodecs