]> granicus.if.org Git - apache/commitdiff
Simplify the initialisation before mod_env's fixup.
authorGraham Leggett <minfrin@apache.org>
Tue, 19 Oct 2010 23:46:29 +0000 (23:46 +0000)
committerGraham Leggett <minfrin@apache.org>
Tue, 19 Oct 2010 23:46:29 +0000 (23:46 +0000)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1024467 13f79535-47bb-0310-9956-ffa450edef68

modules/metadata/mod_env.c

index 8bd07327e36d3c47d21cf054fc99dc989c97f5c3..38932d84c6f902db7c65def9725caf50cd712ed8 100644 (file)
@@ -149,15 +149,15 @@ AP_INIT_ITERATE("UnsetEnv", add_env_module_vars_unset, NULL,
 
 static int fixup_env_module(request_rec *r)
 {
-    apr_table_t *e = r->subprocess_env;
     env_dir_config_rec *sconf = ap_get_module_config(r->per_dir_config,
                                                      &env_module);
-    apr_table_t *vars = sconf->vars;
 
-    if (!apr_table_elts(sconf->vars)->nelts)
+    if (!apr_table_elts(sconf->vars)->nelts) {
         return DECLINED;
+    }
 
-    r->subprocess_env = apr_table_overlay(r->pool, e, vars);
+    r->subprocess_env = apr_table_overlay(r->pool, r->subprocess_env,
+            sconf->vars);
 
     return OK;
 }