Issue 8436: set.__init__ accepts keyword args

diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py
index 1e0a909c0a05f4173b3326687e278e9dec7827e1..627c48c51b4e3335164eed18fd56eec824735b0d 100644 (file)
--- a/Lib/test/test_set.py
+++ b/Lib/test/test_set.py
@@ -48,6 +48,7 @@ class TestJointOps(unittest.TestCase):
 
     def test_new_or_init(self):
         self.assertRaises(TypeError, self.thetype, [], 2)
+        self.assertRaises(TypeError, set().__init__, a=1)
 
     def test_uniquification(self):
         actual = sorted(self.s)

diff --git a/Objects/setobject.c b/Objects/setobject.c
index 944744183c19797cf53e2c548cacbc1af3f636fc..aaa483878e64c9a6ebd1512690225664ae67f994 100644 (file)
--- a/Objects/setobject.c
+++ b/Objects/setobject.c
@@ -1978,6 +1978,8 @@ set_init(PySetObject *self, PyObject *args, PyObject *kwds)
 
        if (!PyAnySet_Check(self))
                return -1;
+       if (PySet_Check(self) && !_PyArg_NoKeywords("set()", kwds))
+               return -1;
        if (!PyArg_UnpackTuple(args, Py_TYPE(self)->tp_name, 0, 1, &iterable))
                return -1;
        set_clear_internal(self);