Add some notes explaining why some validations are not relevant in the dnstap case.

diff --git a/regression-tests.recursor-dnssec/test_RecDnstap.py b/regression-tests.recursor-dnssec/test_RecDnstap.py
index 0669fbc7d9d080aee6910af3e7b68144b41cd792..c94c1b5c2eeae912c057560d3a5fe843da1d3731 100644 (file)
--- a/regression-tests.recursor-dnssec/test_RecDnstap.py
+++ b/regression-tests.recursor-dnssec/test_RecDnstap.py
@@ -43,6 +43,9 @@ def checkDnstapBase(testinstance, dnstap, protocol, initiator):
     testinstance.assertEqual(dnstap.message.socket_protocol, protocol)
     testinstance.assertTrue(dnstap.message.HasField('socket_family'))
     testinstance.assertEquals(dnstap.message.socket_family, dnstap_pb2.INET)
+    #
+    # We cannot check the query address and port since we only log outgoing queries via dnstap
+    #
     #testinstance.assertTrue(dnstap.message.HasField('query_address'))
     #testinstance.assertEquals(socket.inet_ntop(socket.AF_INET, dnstap.message.query_address), initiator)
     testinstance.assertTrue(dnstap.message.HasField('response_address'))
@@ -59,6 +62,10 @@ def checkDnstapQuery(testinstance, dnstap, protocol, query, initiator='127.0.0.1
     testinstance.assertTrue(dnstap.message.HasField('query_time_nsec'))
 
     testinstance.assertTrue(dnstap.message.HasField('query_message'))
+    #
+    # We cannot compare the incoming query with the outgoing one
+    # The IDs and some other fields will be different
+    #
     wire_message = dns.message.from_wire(dnstap.message.query_message)
     #testinstance.assertEqual(wire_message, query)