]> granicus.if.org Git - python/commitdiff
Fix failure in test_poplib after issue #20951.
authorAntoine Pitrou <solipsis@pitrou.net>
Tue, 29 Apr 2014 08:27:09 +0000 (10:27 +0200)
committerAntoine Pitrou <solipsis@pitrou.net>
Tue, 29 Apr 2014 08:27:09 +0000 (10:27 +0200)
Lib/test/test_poplib.py

index d076fc1b9c3fbb77cda654909a3d507ad8e1ab31..d695a0db124ea6a8a26f1750d481ef63b37a9ab9 100644 (file)
@@ -349,23 +349,18 @@ class TestPOP3Class(TestCase):
 
 
 if SUPPORTS_SSL:
+    from test.test_ftplib import SSLConnection
 
-    class DummyPOP3_SSLHandler(DummyPOP3Handler):
+    class DummyPOP3_SSLHandler(SSLConnection, DummyPOP3Handler):
 
         def __init__(self, conn):
             asynchat.async_chat.__init__(self, conn)
-            ssl_socket = ssl.wrap_socket(self.socket, certfile=CERTFILE,
-                                          server_side=True,
-                                          do_handshake_on_connect=False)
-            self.del_channel()
-            self.set_socket(ssl_socket)
-            # Must try handshake before calling push()
-            self.tls_active = True
-            self.tls_starting = True
-            self._do_tls_handshake()
+            self.secure_connection()
             self.set_terminator(b"\r\n")
             self.in_buffer = []
             self.push('+OK dummy pop3 server ready. <timestamp>')
+            self.tls_active = True
+            self.tls_starting = False
 
 
 @requires_ssl