(big surprise). new solution is a little less hackish.
Code gen adds a TupleArg instance in the argument slot. The tuple arg
includes a copy of the names that it is responsble for binding. The
PyAssembler uses this information to calculate the correct argcount.
all fix this wacky case: del (a, ((b,), c)), d
which is the same as: del a, b, c, d
(Can't wait for Guido to tell me why.)
solution uses findOp which walks a tree to find out whether it
contains OP_ASSIGN or OP_DELETE or ...
CO_VARARGS = 0x0004
CO_VARKEYWORDS = 0x0008
+class TupleArg:
+ def __init__(self, count, names):
+ self.count = count
+ self.names = names
+ def __repr__(self):
+ return "TupleArg(%s, %s)" % (self.count, self.names)
+ def getName(self):
+ return ".nested%d" % self.count
+
class PyAssembler:
"""Creates Python code objects
"""
self.insts = []
# used by makeCodeObject
self._getArgCount(args)
+ print name, args, self.argcount
self.code = ''
self.consts = [docstring]
self.filename = filename
self.name = name
self.names = []
self.varnames = list(args) or []
+ for i in range(len(self.varnames)):
+ var = self.varnames[i]
+ if isinstance(var, TupleArg):
+ self.varnames[i] = var.getName()
# lnotab support
self.firstlineno = 0
self.lastlineno = 0
self.lnotab = ''
def _getArgCount(self, args):
- if args and args[0][0] == '.':
- for i in range(len(args)):
- if args[i][0] == '.':
- num = i
- self.argcount = num + 1
- else:
- self.argcount = len(args)
-
+ self.argcount = len(args)
+ if args:
+ for arg in args:
+ if isinstance(arg, TupleArg):
+ numNames = len(misc.flatten(arg.names))
+ self.argcount = self.argcount - numNames
def __repr__(self):
return "<bytecode: %d instrs>" % len(self.insts)
self.flags = self.flags | CO_OPTIMIZED
def setVarArgs(self):
- self.flags = self.flags | CO_VARARGS
+ if not self.flags & CO_VARARGS:
+ self.flags = self.flags | CO_VARARGS
+ self.argcount = self.argcount - 1
def setKWArgs(self):
self.flags = self.flags | CO_VARKEYWORDS
"""
from p2c import transformer, ast
-from pyassem import StackRef, PyAssembler
+from pyassem import StackRef, PyAssembler, TupleArg
import dis
import misc
import marshal
if type(elt) == types.StringType:
args.append(elt)
elif type(elt) == types.TupleType:
- args.append(".nested%d" % count)
+ args.append(TupleArg(count, elt))
count = count + 1
extra.extend(misc.flatten(elt))
else:
def visitLambda(self, node):
node.name = '<lambda>'
- node.varargs = node.kwargs = None
self._visitFuncOrLambda(node, 'Lambda')
return 1
return 1
def visitAssName(self, node):
- # XXX handle OP_DELETE
- if node.flags != 'OP_ASSIGN':
+ if node.flags == 'OP_ASSIGN':
+ self.storeName(node.name)
+ elif node.flags == 'OP_DELETE':
+ self.delName(node.name)
+ else:
print "oops", node.flags
- self.storeName(node.name)
+ return 1
def visitAssAttr(self, node):
self.visit(node.expr)
return 1
def visitAssTuple(self, node):
- self.emit('UNPACK_TUPLE', len(node.nodes))
+ if findOp(node) != 'OP_DELETE':
+ self.emit('UNPACK_TUPLE', len(node.nodes))
for child in node.nodes:
self.visit(child)
return 1
else:
self.visit(node.globals)
self.emit('EXEC_STMT')
+ return 1
class LocalNameFinder:
def __init__(self, names=()):
def visitAssName(self, node):
self.names.add(node.name)
+class OpFinder:
+ def __init__(self):
+ self.op = None
+ def visitAssName(self, node):
+ if self.op is None:
+ self.op = node.flags
+ elif self.op != node.flags:
+ raise ValueError, "mixed ops in stmt"
+
+def findOp(node):
+ v = OpFinder()
+ walk(node, v)
+ return v.op
+
class Loop:
def __init__(self):
self.startAnchor = StackRef()
CO_VARARGS = 0x0004
CO_VARKEYWORDS = 0x0008
+class TupleArg:
+ def __init__(self, count, names):
+ self.count = count
+ self.names = names
+ def __repr__(self):
+ return "TupleArg(%s, %s)" % (self.count, self.names)
+ def getName(self):
+ return ".nested%d" % self.count
+
class PyAssembler:
"""Creates Python code objects
"""
self.insts = []
# used by makeCodeObject
self._getArgCount(args)
+ print name, args, self.argcount
self.code = ''
self.consts = [docstring]
self.filename = filename
self.name = name
self.names = []
self.varnames = list(args) or []
+ for i in range(len(self.varnames)):
+ var = self.varnames[i]
+ if isinstance(var, TupleArg):
+ self.varnames[i] = var.getName()
# lnotab support
self.firstlineno = 0
self.lastlineno = 0
self.lnotab = ''
def _getArgCount(self, args):
- if args and args[0][0] == '.':
- for i in range(len(args)):
- if args[i][0] == '.':
- num = i
- self.argcount = num + 1
- else:
- self.argcount = len(args)
-
+ self.argcount = len(args)
+ if args:
+ for arg in args:
+ if isinstance(arg, TupleArg):
+ numNames = len(misc.flatten(arg.names))
+ self.argcount = self.argcount - numNames
def __repr__(self):
return "<bytecode: %d instrs>" % len(self.insts)
self.flags = self.flags | CO_OPTIMIZED
def setVarArgs(self):
- self.flags = self.flags | CO_VARARGS
+ if not self.flags & CO_VARARGS:
+ self.flags = self.flags | CO_VARARGS
+ self.argcount = self.argcount - 1
def setKWArgs(self):
self.flags = self.flags | CO_VARKEYWORDS
"""
from p2c import transformer, ast
-from pyassem import StackRef, PyAssembler
+from pyassem import StackRef, PyAssembler, TupleArg
import dis
import misc
import marshal
if type(elt) == types.StringType:
args.append(elt)
elif type(elt) == types.TupleType:
- args.append(".nested%d" % count)
+ args.append(TupleArg(count, elt))
count = count + 1
extra.extend(misc.flatten(elt))
else:
def visitLambda(self, node):
node.name = '<lambda>'
- node.varargs = node.kwargs = None
self._visitFuncOrLambda(node, 'Lambda')
return 1
return 1
def visitAssName(self, node):
- # XXX handle OP_DELETE
- if node.flags != 'OP_ASSIGN':
+ if node.flags == 'OP_ASSIGN':
+ self.storeName(node.name)
+ elif node.flags == 'OP_DELETE':
+ self.delName(node.name)
+ else:
print "oops", node.flags
- self.storeName(node.name)
+ return 1
def visitAssAttr(self, node):
self.visit(node.expr)
return 1
def visitAssTuple(self, node):
- self.emit('UNPACK_TUPLE', len(node.nodes))
+ if findOp(node) != 'OP_DELETE':
+ self.emit('UNPACK_TUPLE', len(node.nodes))
for child in node.nodes:
self.visit(child)
return 1
else:
self.visit(node.globals)
self.emit('EXEC_STMT')
+ return 1
class LocalNameFinder:
def __init__(self, names=()):
def visitAssName(self, node):
self.names.add(node.name)
+class OpFinder:
+ def __init__(self):
+ self.op = None
+ def visitAssName(self, node):
+ if self.op is None:
+ self.op = node.flags
+ elif self.op != node.flags:
+ raise ValueError, "mixed ops in stmt"
+
+def findOp(node):
+ v = OpFinder()
+ walk(node, v)
+ return v.op
+
class Loop:
def __init__(self):
self.startAnchor = StackRef()
projects / python / commitdiff