Don't rename .partial files in pg_receivexlog if an error occured

In 56c7d8d the behavior to keep .partial segments around
(considered corrupt) in case an connection failure occurs was
accidentally removed. This would lead to an incomplete segment
being considered complete.

Author: Michael Paquier

diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
index 4382e5d76a1a6d1ec9a8e08f85bdc94787ec1c33..568ff176ef5c57932143701d718ba614fcd7d2fc 100644 (file)
--- a/src/bin/pg_basebackup/receivelog.c
+++ b/src/bin/pg_basebackup/receivelog.c
@@ -679,7 +679,7 @@ ReceiveXlogStream(PGconn *conn, StreamCtl *stream)
        }
 
 error:
-       if (walfile != NULL && stream->walmethod->close(walfile, CLOSE_NORMAL) != 0)
+       if (walfile != NULL && stream->walmethod->close(walfile, CLOSE_NO_RENAME) != 0)
                fprintf(stderr, _("%s: could not close file \"%s\": %s\n"),
                  progname, current_walfile_name, stream->walmethod->getlasterror());
        walfile = NULL;