Coverity issue CID #169

local_ptr_assign_local: Assigning address of stack variable "namebuf" to pointer "filename"
out_of_scope: Variable "namebuf" goes out of scope
use_invalid: Used "filename" pointing to out-of-scope variable "namebuf"

diff --git a/Python/traceback.c b/Python/traceback.c
index d6f68ab169258c7f8bcaf14c1ffa37c3d8ccbc35..877ca5a475dc92df0bc35058dea015e0a66a3bad 100644 (file)
--- a/Python/traceback.c
+++ b/Python/traceback.c
@@ -129,6 +129,8 @@ tb_displayline(PyObject *f, char *filename, int lineno, char *name)
        FILE *xfp;
        char linebuf[2000];
        int i;
+       char namebuf[MAXPATHLEN+1];
+
        if (filename == NULL || name == NULL)
                return -1;
        /* This is needed by Emacs' compile command */
@@ -147,7 +149,6 @@ tb_displayline(PyObject *f, char *filename, int lineno, char *name)
                        Py_ssize_t _npath = PyList_Size(path);
                        int npath = Py_SAFE_DOWNCAST(_npath, Py_ssize_t, int);
                        size_t taillen = strlen(tail);
-                       char namebuf[MAXPATHLEN+1];
                        for (i = 0; i < npath; i++) {
                                PyObject *v = PyList_GetItem(path, i);
                                if (v == NULL) {