]> granicus.if.org Git - zfs/commitdiff
zfs_receive_010_pos: change dd arguments
authorGeorge Melikov <mail@gmelikov.ru>
Thu, 20 Apr 2017 19:05:39 +0000 (23:05 +0400)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Thu, 20 Apr 2017 19:05:39 +0000 (12:05 -0700)
The  `dd` command as written will not create a hole in the file.
Additionally, the `stride` argument isn't understood by `dd` so
it's replaced with `seek` which isn't equivilant but will result in
a single whole which is sufficient for the test case.  Finally,
`conv=notrunc` is added to avoid truncating the file.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes #6023

tests/zfs-tests/tests/functional/cli_root/zfs_receive/zfs_receive_010_pos.ksh

index a9c0a47a3a9b5bc66b3c1b41e8fdabda211f682c..820e05656f68416ff006d48dae1a0d35fb431917 100755 (executable)
@@ -53,9 +53,9 @@ function make_object
        if [[ $type == "file" ]]; then
                dd if=/dev/urandom of=${mntpnt}/f$objnum bs=512 count=16
        elif [[ $type == "hole1" ]]; then
-               dd if=/dev/urandom of=${mntpnt}/fh$objnum bs=512 count=5 stride=4
+               dd if=/dev/zero of=${mntpnt}/fh$objnum bs=512 count=5 seek=4 conv=notrunc
        elif [[ $type == "hole2" ]]; then
-               dd if=/dev/urandom of=${mntpnt}/fh$objnum bs=512 count=4 stride=5
+               dd if=/dev/zero of=${mntpnt}/fh$objnum bs=512 count=4 seek=5 conv=notrunc
        elif [[ $type == "directory" ]]; then
                mkdir ${mntpnt}/d$objnum
        elif [[ $type == "missing" ]]; then