]> granicus.if.org Git - apache/commitdiff
mod_proxy: follow up to r1601291.
authorYann Ylavic <ylavic@apache.org>
Tue, 10 Jun 2014 13:23:20 +0000 (13:23 +0000)
committerYann Ylavic <ylavic@apache.org>
Tue, 10 Jun 2014 13:23:20 +0000 (13:23 +0000)
Since deferred_write_pool is needed by the core_output_filter and is a subpool
of the connection, shutdown in a pre_cleanup of the connection's pool to avoid
a freed memory access (SEGV).

Reported By: takashi

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1601630 13f79535-47bb-0310-9956-ffa450edef68

modules/proxy/proxy_util.c

index 513b8657197a7c683ad009c78b4e9d745376e661..8e2942f1a1eab75777707c39a3e91322d492681e 100644 (file)
@@ -2917,8 +2917,7 @@ PROXY_DECLARE(int) ap_proxy_connection_create(const char *proxy_function,
     /* Shutdown the connection before closing it (eg. SSL connections
      * need to be close-notify-ed).
      */
-    apr_pool_cleanup_register(conn->scpool, conn, connection_shutdown,
-                              apr_pool_cleanup_null);
+    apr_pool_pre_cleanup_register(conn->scpool, conn, connection_shutdown);
 
     return OK;
 }