]> granicus.if.org Git - libmatroska/commitdiff
use push_back
authorRosen Penev <rosenp@gmail.com>
Tue, 4 Oct 2022 01:36:02 +0000 (18:36 -0700)
committerRosen Penev <rosenp@gmail.com>
Sat, 15 Oct 2022 18:58:16 +0000 (11:58 -0700)
This is a vector. No need for iterators.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
src/KaxBlock.cpp

index 90fb4f3d67e21acd3b40f44129e50fe83bc91177..041ba733657c20f059fdfddafa8e011a02ccb586 100644 (file)
@@ -76,7 +76,6 @@ KaxInternalBlock::~KaxInternalBlock()
 
 KaxInternalBlock::KaxInternalBlock(const KaxInternalBlock & ElementToClone)
   :EbmlBinary(ElementToClone)
-  ,myBuffers(ElementToClone.myBuffers.size())
   ,Timecode(ElementToClone.Timecode)
   ,LocalTimecode(ElementToClone.LocalTimecode)
   ,bLocalTimecodeUsed(ElementToClone.bLocalTimecodeUsed)
@@ -84,11 +83,9 @@ KaxInternalBlock::KaxInternalBlock(const KaxInternalBlock & ElementToClone)
   ,ParentCluster(ElementToClone.ParentCluster) ///< \todo not exactly
 {
   // add a clone of the list
-  auto myItr = myBuffers.begin();
-  for (const auto& buffer : ElementToClone.myBuffers) {
-    *myItr = buffer->Clone();
-    ++myItr;
-  }
+  myBuffers.reserve(ElementToClone.myBuffers.size());
+  for (const auto& buffer : ElementToClone.myBuffers)
+    myBuffers.push_back(buffer->Clone());
 }