]> granicus.if.org Git - python/commitdiff
bpo-37558: Shared memory tests are failing due to double slashes (GH-14703)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 11 Jul 2019 18:38:37 +0000 (11:38 -0700)
committerGitHub <noreply@github.com>
Thu, 11 Jul 2019 18:38:37 +0000 (11:38 -0700)
With the addition of shared memory into Python 3.8, we now have three tests failing on Solaris, namely `test_multiprocessing_fork`, `test_multiprocessing_forkserver` and `test_multiprocessing_spawn`. The reason seems to be incorrect name handling which results in two slashes being prepended.

https://bugs.python.org/issue37558
(cherry picked from commit 4737265622251756a9480ab84af2442b6b986850)

Co-authored-by: Jakub KulĂ­k <Kulikjak@gmail.com>
Lib/test/_test_multiprocessing.py
Misc/NEWS.d/next/Tests/2019-07-11-10-33-56.bpo-37558.SKHRsL.rst [new file with mode: 0644]

index 9a39f385952fae05338046d0fcfbe786d5c5ca79..2fe0def2bcd27783a42090fb78c0b57ef830d3a5 100644 (file)
@@ -3990,7 +3990,7 @@ class _TestSharedMemory(BaseTestCase):
 
             # Create a shared_memory segment, and send the segment name
             sm = shared_memory.SharedMemory(create=True, size=10)
-            sys.stdout.write(sm._name + '\\n')
+            sys.stdout.write(sm.name + '\\n')
             sys.stdout.flush()
             time.sleep(100)
         '''
diff --git a/Misc/NEWS.d/next/Tests/2019-07-11-10-33-56.bpo-37558.SKHRsL.rst b/Misc/NEWS.d/next/Tests/2019-07-11-10-33-56.bpo-37558.SKHRsL.rst
new file mode 100644 (file)
index 0000000..9f393d7
--- /dev/null
@@ -0,0 +1 @@
+Fix test_shared_memory_cleaned_after_process_termination name handling