]> granicus.if.org Git - php/commitdiff
- Fixed bug #49059 (DateTime::diff() repeats previous sub() operation).
authorDerick Rethans <derick@php.net>
Sun, 7 Mar 2010 17:25:16 +0000 (17:25 +0000)
committerDerick Rethans <derick@php.net>
Sun, 7 Mar 2010 17:25:16 +0000 (17:25 +0000)
ext/date/php_date.c
ext/date/tests/bug49059.phpt [new file with mode: 0644]

index 40e75a6d6643f0cc1a8d7b8338f9e68fef6c1932..955e91d86dbb08be0b696d375509cde8d0296ed3 100644 (file)
@@ -3009,6 +3009,8 @@ PHP_FUNCTION(date_sub)
        timelib_update_ts(dateobj->time, NULL);
        timelib_update_from_sse(dateobj->time);
 
+       dateobj->time->have_relative = 0;
+
        RETURN_ZVAL(object, 1, 0);
 }
 /* }}} */
diff --git a/ext/date/tests/bug49059.phpt b/ext/date/tests/bug49059.phpt
new file mode 100644 (file)
index 0000000..48d2dac
--- /dev/null
@@ -0,0 +1,34 @@
+--TEST--
+Bug #49059 (DateTime::diff() repeats previous sub() operation)
+--FILE--
+<?php
+date_default_timezone_set('Asia/Calcutta');
+
+$date1 = date_create("2009-03-27");
+$date2 = date_create("2009-03-01");
+print "\$date1 at init: " . $date1->format("Y-m-d") . "\n";
+print "\$date2 at init: " . $date2->format("Y-m-d") . "\n";
+$diff = $date1->diff($date2);
+print "\$date1 after first diff: " . $date1->format("Y-m-d") . "\n";
+print "\$diff->days after first diff: " . $diff->days . "\n";
+$date1 = $date1->sub(new DateInterval("P2D"));
+print "\$date1 after sub: " . $date1->format("Y-m-d") . "\n";
+$diff = $date1->diff($date2);
+print "\$date1 after second diff (called at \$date1): " .
+$date1->format("Y-m-d") . "\n";
+print "\$diff->days after second diff: " . $diff->days . "\n";
+$diff = $date2->diff($date1);
+print "\$date1 after third diff (called at \$date2): " .
+$date1->format("Y-m-d") . "\n";
+print "\$diff->days after third diff: " . $diff->days . "\n";
+?>
+--EXPECT--
+$date1 at init: 2009-03-27
+$date2 at init: 2009-03-01
+$date1 after first diff: 2009-03-27
+$diff->days after first diff: 26
+$date1 after sub: 2009-03-25
+$date1 after second diff (called at $date1): 2009-03-25
+$diff->days after second diff: 24
+$date1 after third diff (called at $date2): 2009-03-25
+$diff->days after third diff: 24