]> granicus.if.org Git - python/commitdiff
bpo-37100: Fix test_coroutines with -Werror (GH-13756)
authorVictor Stinner <vstinner@redhat.com>
Sun, 2 Jun 2019 23:35:37 +0000 (01:35 +0200)
committerGitHub <noreply@github.com>
Sun, 2 Jun 2019 23:35:37 +0000 (01:35 +0200)
test_coroutines: test_unawaited_warning_when_module_broken() now uses
support.check_warnings() to catch expected RuntimeWarning.

Lib/test/test_coroutines.py

index 0e7eb3a1af47eb1c46573a2ab06b0cee2ce01144..b406b1c3ebf846adcb127b62dad3c7c174abe032 100644 (file)
@@ -2250,7 +2250,8 @@ class OriginTrackingTest(unittest.TestCase):
         try:
             warnings._warn_unawaited_coroutine = lambda coro: 1/0
             with support.catch_unraisable_exception() as cm, \
-                 support.captured_stderr() as stream:
+                 support.check_warnings((r'coroutine .* was never awaited',
+                                         RuntimeWarning)):
                 # only store repr() to avoid keeping the coroutine alive
                 coro = corofn()
                 coro_repr = repr(coro)
@@ -2261,13 +2262,12 @@ class OriginTrackingTest(unittest.TestCase):
 
                 self.assertEqual(repr(cm.unraisable.object), coro_repr)
                 self.assertEqual(cm.unraisable.exc_type, ZeroDivisionError)
-                self.assertIn("was never awaited", stream.getvalue())
 
             del warnings._warn_unawaited_coroutine
-            with support.captured_stderr() as stream:
+            with support.check_warnings((r'coroutine .* was never awaited',
+                                         RuntimeWarning)):
                 corofn()
                 support.gc_collect()
-            self.assertIn("was never awaited", stream.getvalue())
 
         finally:
             warnings._warn_unawaited_coroutine = orig_wuc