now set errno to EACCES if not a regular file or not executable

diff --git a/goodpath.c b/goodpath.c
index b8d11532783b210eec3a9ec50fb8b12190d9601f..12eaacb02a9e833a92a9ebb99807a45f3f185353 100644 (file)
--- a/goodpath.c
+++ b/goodpath.c
@@ -84,9 +84,16 @@ char * sudo_goodpath(path)
     /* discard root perms */
     set_perms(PERM_USER);
 
+    /* stat(3) failed */
+    if (!err)
+       return(NULL);
+
     /* make sure path describes an executable regular file */
-    if (!err && S_ISREG(statbuf.st_mode) &&(statbuf.st_mode & 0000111))
+    if (S_ISREG(statbuf.st_mode) && (statbuf.st_mode & 0000111)) {
        return((char *)path);
-    else
+    } else {
+       /* file is not executable/regular */
+       errno = EACCES;
        return(NULL);
+    }
 }