]> granicus.if.org Git - python/commitdiff
bpo-30132: distutils BuildExtTestCase use temp_cwd (#1387) (#1388)
authorVictor Stinner <victor.stinner@gmail.com>
Tue, 2 May 2017 14:26:04 +0000 (16:26 +0200)
committerGitHub <noreply@github.com>
Tue, 2 May 2017 14:26:04 +0000 (16:26 +0200)
BuildExtTestCase of test_distutils now uses support.temp_cwd() in
setUp() to remove files created in the current working in all
BuildExtTestCase unit tests, not only test_build_ext().

Fix the following warning:

Warning -- files was modified by test_distutils
  Before: []
  After:  ['vc140.pdb']
(cherry picked from commit 30768958490c658fba0fe24f1cabbdad44be22ff)

Lib/distutils/tests/test_build_ext.py

index f3df564e37347d6f20f0ba9bb55deed89b9916ea..ce13227126f74f08b75faf1c8e378bcb32dff625 100644 (file)
@@ -37,6 +37,13 @@ class BuildExtTestCase(TempdirManager,
         from distutils.command import build_ext
         build_ext.USER_BASE = site.USER_BASE
 
+        # bpo-30132: On Windows, a .pdb file may be created in the current
+        # working directory. Create a temporary working directory to cleanup
+        # everything at the end of the test.
+        self.temp_cwd = support.temp_cwd()
+        self.temp_cwd.__enter__()
+        self.addCleanup(self.temp_cwd.__exit__, None, None, None)
+
     def build_ext(self, *args, **kwargs):
         return build_ext(*args, **kwargs)