Handle single-line and empty commit subjects

If commit object ends with \0 after subject line, then info->subject
was not set.

This commit fixes this and also sets subject to ** empty ** if it
would otherwise be empty, so that there is something to click on.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>

diff --git a/parsing.c b/parsing.c
index 4420e5867cacf716df3aec1649241acd3354dced..b86467aed5a8720d6bbd829fe81cc852410e8dc9 100644 (file)
--- a/parsing.c
+++ b/parsing.c
@@ -234,14 +234,19 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
                p = strchr(p, '\n') + 1;
 
        t = strchr(p, '\n');
-       if (t && *t) {
-               ret->subject = substr(p, t);
+       if (t) {
+               if (*t == '\0')
+                       ret->subject = strdup("** empty **");
+               else
+                       ret->subject = substr(p, t);
                p = t + 1;
 
                while (*p == '\n')
                        p = strchr(p, '\n') + 1;
                ret->msg = p;
-       }
+       } else
+               ret->subject = substr(p, p+strlen(p));
+
        return ret;
 }