Fix oversight in recent pg_basebackup fix causing pg_receivexlog failures.

A oversight in 2c0a485896 causes 'could not create archive status file
"...": No such file or directory' errors in pg_receivexlog if the
target directory doesn't happen to contain a archive_status
directory. That's due to a stupidly left over 'true' constant instead
of mark_done being passed down to ProcessXLogDataMsg().

The bug is only present in the master branch, and luckily wasn't
released.

Spotted by Fujii Masao.

diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
index dc1d7d864845f38d6f2cc074ca6f21774c675d3c..30c4b106522e1f83f34cddc7576106dc0333e9c5 100644 (file)
--- a/src/bin/pg_basebackup/receivelog.c
+++ b/src/bin/pg_basebackup/receivelog.c
@@ -906,7 +906,7 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,
                        {
                                if (!ProcessXLogDataMsg(conn, copybuf, r, &blockpos,
                                                                                timeline, basedir, stream_stop,
-                                                                               partial_suffix, true))
+                                                                               partial_suffix, mark_done))
                                        goto error;
 
                                /*