]> granicus.if.org Git - clang/commitdiff
Fix use after free through StringRef.
authorNick Lewycky <nicholas@mxc.ca>
Wed, 4 May 2011 02:06:19 +0000 (02:06 +0000)
committerNick Lewycky <nicholas@mxc.ca>
Wed, 4 May 2011 02:06:19 +0000 (02:06 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130828 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Driver/Tools.cpp

index bf73ca2c3001b0853a0e903a2e435b5e70e6e6f6..f2b685b8b23c8105dfb82126185b15d247d7925a 100644 (file)
@@ -643,8 +643,9 @@ void Clang::AddMIPSTargetArgs(const ArgList &Args,
   CmdArgs.push_back("-target-abi");
   CmdArgs.push_back(ABIName);
 
+  std::string MArch;
   if (const Arg *A = Args.getLastArg(options::OPT_march_EQ)) {
-    llvm::StringRef MArch = A->getValue(Args);
+    MArch = A->getValue(Args);
     CmdArgs.push_back("-target-cpu");
 
     if ((MArch == "r2000") || (MArch == "r3000"))
@@ -652,7 +653,7 @@ void Clang::AddMIPSTargetArgs(const ArgList &Args,
     else if (MArch == "r6000")
       CmdArgs.push_back("mips2");
     else
-      CmdArgs.push_back(MArch.str().c_str());
+      CmdArgs.push_back(MArch.c_str());
   }
 
   // Select the float ABI as determined by -msoft-float, -mhard-float, and