]> granicus.if.org Git - libvpx/commitdiff
Revert "quantize ssse3: declare all variables"
authorJames Zern <jzern@google.com>
Fri, 28 Jul 2017 08:21:28 +0000 (01:21 -0700)
committerJames Zern <jzern@google.com>
Fri, 28 Jul 2017 08:22:16 +0000 (01:22 -0700)
This reverts commit 03f5e300d69d368290305e19cc66bac8b0ea1ff8.

This causes test failures under OSX:
SSSE3/VP9QuantizeTest.EOBCheck/0
SSSE3/VP9QuantizeTest.OperationCheck/0

Change-Id: I122732717ead1f7af5b04c529a6948e382e5e59b

test/vp9_quantize_test.cc
vpx_dsp/x86/quantize_ssse3_x86_64.asm

index e2c549b44352d2f337c9072e227f2771cdf689c9..cffcda2ff9e8fa09d058a4e4e0efe976f70b9381 100644 (file)
@@ -381,7 +381,7 @@ INSTANTIATE_TEST_CASE_P(SSE2, VP9QuantizeTest,
 
 // TODO(johannkoenig): SSSE3 optimizations do not yet pass these tests.
 #if HAVE_SSSE3 && ARCH_X86_64
-INSTANTIATE_TEST_CASE_P(SSSE3, VP9QuantizeTest,
+INSTANTIATE_TEST_CASE_P(DISABLED_SSSE3, VP9QuantizeTest,
                         ::testing::Values(make_tuple(&vpx_quantize_b_ssse3,
                                                      &vpx_quantize_b_c,
                                                      VPX_BITS_8)));
index d0e1beb14eea68e074afcaf96f48c2b1deb21ea1..ec2cafb94cd6ffd2e3e9cfe2b50590a18d8cc0b2 100644 (file)
@@ -15,6 +15,7 @@ pw_1: times 8 dw 1
 
 SECTION .text
 
+; TODO(yunqingwang)fix quantize_b code for skip=1 case.
 %macro QUANTIZE_FN 2
 cglobal quantize_%1, 0, %2, 15, coeff, ncoeff, skip, zbin, round, quant, \
                                 shift, qcoeff, dqcoeff, dequant, \
@@ -303,9 +304,6 @@ cglobal quantize_%1, 0, %2, 15, coeff, ncoeff, skip, zbin, round, quant, \
 
   ; skip-block, i.e. just write all zeroes
 .blank:
-DEFINE_ARGS coeff, ncoeff, skip, zbin, round, quant, shift, \
-            qcoeff, dqcoeff, dequant, eob, scan, iscan
-
   mov                             r0, dqcoeffmp
   movifnidn                  ncoeffq, ncoeffmp
   mov                             r2, qcoeffmp