]> granicus.if.org Git - python/commitdiff
Issue #19255: Clear error after failed PyDict_SetItem() on shutdown.
authorSerhiy Storchaka <storchaka@gmail.com>
Wed, 12 Feb 2014 07:55:45 +0000 (09:55 +0200)
committerSerhiy Storchaka <storchaka@gmail.com>
Wed, 12 Feb 2014 07:55:45 +0000 (09:55 +0200)
This silences a Coverity complain.

Objects/moduleobject.c

index 682171070ec34c4476bd6dbd89c1bef19c9a66f2..f509932a306bee9ae977377da62e2a04ceb79fd9 100644 (file)
@@ -330,7 +330,8 @@ _PyModule_ClearDict(PyObject *d)
                     else
                         PyErr_Clear();
                 }
-                PyDict_SetItem(d, key, Py_None);
+                if (PyDict_SetItem(d, key, Py_None) != 0)
+                    PyErr_Clear();
             }
         }
     }
@@ -349,7 +350,8 @@ _PyModule_ClearDict(PyObject *d)
                     else
                         PyErr_Clear();
                 }
-                PyDict_SetItem(d, key, Py_None);
+                if (PyDict_SetItem(d, key, Py_None) != 0)
+                    PyErr_Clear();
             }
         }
     }