]> granicus.if.org Git - ejabberd/commitdiff
XEP-0198: Don't log protocol issues
authorHolger Weiss <holger@zedat.fu-berlin.de>
Sun, 4 May 2014 23:11:14 +0000 (01:11 +0200)
committerHolger Weiss <holger@zedat.fu-berlin.de>
Sun, 4 May 2014 23:11:14 +0000 (01:11 +0200)
There are corner cases where certain clients acknowledge more stanzas
than they received.  Nothing really bad will happen in those cases, and
server administrators can't do anything about such issues anyway.

src/ejabberd_c2s.erl

index 314f07f8c683c6d4a8b00e4c219f1189a760e8a2..a1774b73a502c3edb075a5a87a5e2af4f4539155 100644 (file)
@@ -2672,10 +2672,6 @@ handle_r(StateData) ->
 
 handle_a(#state{jid = JID, n_stanzas_out = NumStanzasOut} = StateData, Attrs) ->
     case catch jlib:binary_to_integer(xml:get_attr_s(<<"h">>, Attrs)) of
-      H when is_integer(H), H > NumStanzasOut ->
-         ?WARNING_MSG("~s acknowledged ~B stanzas, but only ~B were sent",
-                      [jlib:jid_to_string(JID), H, NumStanzasOut]),
-         ack_queue_drop(StateData, NumStanzasOut);
       H when is_integer(H), H >= 0 ->
          ?DEBUG("~s acknowledged ~B of ~B stanzas",
                 [jlib:jid_to_string(JID), H, NumStanzasOut]),