]> granicus.if.org Git - apache/commitdiff
the cost of synchronized SMP proof updates far outweighs the value of having
authorGreg Ames <gregames@apache.org>
Fri, 20 Jul 2007 16:20:10 +0000 (16:20 +0000)
committerGreg Ames <gregames@apache.org>
Fri, 20 Jul 2007 16:20:10 +0000 (16:20 +0000)
100% accurate MaxRequestsPerChild.
* it doesn't even count requests, it counts connections.
* all it is is a number someone pulls out of a hat in an attempt to deal with
  resource leaks.
i.e., no strong need for accuracy.

atomic operations are relatively expensive and this is mainline code.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@558039 13f79535-47bb-0310-9956-ffa450edef68

server/mpm/worker/worker.c

index 5b531c6ede4b805c72e04825399859539ab4f14c..dbf021541d81cbf84a715111ed680fb314a263a9 100644 (file)
@@ -892,7 +892,7 @@ worker_pop:
         bucket_alloc = apr_bucket_alloc_create(ptrans);
         process_socket(ptrans, csd, process_slot, thread_slot, bucket_alloc);
         worker_sockets[thread_slot] = NULL;
-        requests_this_child--; /* FIXME: should be synchronized - aaron */
+        requests_this_child--; 
         apr_pool_clear(ptrans);
         last_ptrans = ptrans;
     }