Remove ill-conceived Assertion in ProcessClientWriteInterrupt().

It's perfectly fine to have blocked interrupts when
ProcessClientWriteInterrupt() is called. In fact it's commonly the
case when emitting error reports. And we deal with that correctly.

Even if that'd not be the case, it'd be a bad location for such a
assertion. Because ProcessClientWriteInterrupt() is only called when
the socket is blocked it's hard to hit.

Per Heikki and buildfarm animals nightjar and dunlin.

diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
index f2a426d792a4e588a6bc16f4cfde41eb821925cd..28af40c3dc6a4f3ff599f2ff004e3e61f55ddc4f 100644 (file)
--- a/src/backend/tcop/postgres.c
+++ b/src/backend/tcop/postgres.c
@@ -571,8 +571,6 @@ ProcessClientWriteInterrupt(bool blocked)
 {
        int                     save_errno = errno;
 
-       Assert(InterruptHoldoffCount == 0 && CritSectionCount == 0);
-
        /*
         * We only want to process the interrupt here if socket writes are
         * blocking to increase the chance to get an error message to the