]> granicus.if.org Git - postgresql/commitdiff
Remove useless if-test.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 25 Mar 2018 18:54:16 +0000 (14:54 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 25 Mar 2018 18:54:16 +0000 (14:54 -0400)
Coverity complained that this check is pointless, and it's right.
There is no case where we'd call ExecutorStart with a null plannedstmt,
and if we did, it'd have crashed before here.  Thinko in commit cc415a56d.

src/backend/executor/execMain.c

index 890067757c0c8f71de5b7511e0ecf17155481847..f47c691d12b9d4f7cd53b9213666102785d8e365 100644 (file)
@@ -249,9 +249,7 @@ standard_ExecutorStart(QueryDesc *queryDesc, int eflags)
        estate->es_crosscheck_snapshot = RegisterSnapshot(queryDesc->crosscheck_snapshot);
        estate->es_top_eflags = eflags;
        estate->es_instrument = queryDesc->instrument_options;
-
-       if (queryDesc->plannedstmt)
-               estate->es_jit_flags = queryDesc->plannedstmt->jitFlags;
+       estate->es_jit_flags = queryDesc->plannedstmt->jitFlags;
 
        /*
         * Set up an AFTER-trigger statement context, unless told not to, or