ICU-20479 don’t leave junk in source directory on configure or make check

- see also ICU-20062
- add a `-B` option to the two python invocations on Windows
- set PYTHONDONTWRITEBYTECODE in configure.ac and icudefs.mk.in

Co-authored-by: Fredrik Roubert <roubert@google.com>

diff --git a/icu4c/source/configure b/icu4c/source/configure
index 7d704b04ad836efa2660231b2cb68cd3a3fa2f4f..f36fe0a2cafb36c58d45acb9f5bd7a4ee8900094 100755 (executable)
--- a/icu4c/source/configure
+++ b/icu4c/source/configure
@@ -2603,6 +2603,10 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
 
 
 
+# Instruct Python to never write any byte code to the ICU source tree.
+PYTHONDONTWRITEBYTECODE=1
+export PYTHONDONTWRITEBYTECODE
+
 
 
 

diff --git a/icu4c/source/configure.ac b/icu4c/source/configure.ac
index 6c4cb06f93f3370e18d3c87571e2e18d1a5f9e14..c8aef749c4caf9f1a06fca88f22d11d79209649b 100644 (file)
--- a/icu4c/source/configure.ac
+++ b/icu4c/source/configure.ac
@@ -16,6 +16,10 @@ AC_INIT([ICU],
         [International Components for Unicode],
         [http://icu-project.org])
 
+# Instruct Python to never write any byte code to the ICU source tree.
+PYTHONDONTWRITEBYTECODE=1
+export PYTHONDONTWRITEBYTECODE
+
 AC_CONFIG_MACRO_DIR([config/m4])
 AC_CONFIG_SRCDIR([common/unicode/utypes.h])
 

diff --git a/icu4c/source/data/makedata.mak b/icu4c/source/data/makedata.mak
index 9991d062f69385080566e11b6eb8e1435b9229e0..1f42124ae5a0676ba28118af3ae63f507c165f9d 100644 (file)
--- a/icu4c/source/data/makedata.mak
+++ b/icu4c/source/data/makedata.mak
@@ -233,7 +233,7 @@ $(TOOLS_TS): "$(ICUTOOLS)\genrb\$(CFGTOOLS)\genrb.exe" "$(ICUTOOLS)\gencnval\$(C
 
 $(COREDATA_TS):
        @cd "$(ICUSRCDATA)"
-       py -3 -m buildtool \
+       py -3 -B -m buildtool \
                --mode windows-exec \
                --src_dir "$(ICUSRCDATA)" \
                --tool_dir "$(ICUTOOLS)" \

diff --git a/icu4c/source/icudefs.mk.in b/icu4c/source/icudefs.mk.in
index 9abb8720ece1261ea2c2597f21e5a5ba0b6300ea..59d82052fc9d17ffe115c44a9c6038d76058c255 100644 (file)
--- a/icu4c/source/icudefs.mk.in
+++ b/icu4c/source/icudefs.mk.in
@@ -17,6 +17,9 @@
 
 SHELL = @SHELL@
 
+# Instruct Python to never write any byte code to the ICU source tree.
+export PYTHONDONTWRITEBYTECODE = 1
+
 # Standard directories
 
 prefix = @prefix@

diff --git a/icu4c/source/test/testdata/testdata.mak b/icu4c/source/test/testdata/testdata.mak
index a74ba08f329bdd4fa35c7dd813453c4ca4887e56..879af99f991514b4b3d11230f7dffef59fb15f4f 100644 (file)
--- a/icu4c/source/test/testdata/testdata.mak
+++ b/icu4c/source/test/testdata/testdata.mak
@@ -35,7 +35,7 @@ CREATE_DIRS :
 "$(TESTDATAOUT)\testdata.dat" :
        @echo Building test data
        set PYTHONPATH=$(ICUSRCDATA);%PYTHONPATH%
-       py -3 -m buildtool \
+       py -3 -B -m buildtool \
                --mode windows-exec \
                --tool_dir "$(ICUTOOLS)" \
                --tool_cfg "$(CFG)" \