Fix a segmentation fault in the Python extension by initializing *defaultdict

with NULL. Thanks for Peter Palfrader for the patch in the Debian BTS.

git-svn-id: file:///tmp/cracklib-svn/trunk@172 4175fe1e-86d5-4fdc-8e6a-506fab9d8533

diff --git a/cracklib/NEWS b/cracklib/NEWS
index e06ec02e89f249d957da1d88470095853a3512ae..86a1587e4c4dabea848f9e2185e1c12acdd870a7 100644 (file)
--- a/cracklib/NEWS
+++ b/cracklib/NEWS
@@ -1,7 +1,8 @@
-v2.8.18 fixed compilation on interix systems
+v2.8.17 fixed compilation on interix systems
         updated Hindi translation (Rajesh Ranjan)
-v2.8.17 fixed NLS issue in cracklib-check
+        fixed NLS issue in cracklib-check
         add Ukrainian translation (Yuri Chornoivan)
+        fix segmentation fault in Python extension (Peter Palfrader)
 v2.8.16 update licensing information in Python extension (Jan Dittberner)
         make translations work in Python extension (Jan Dittberner)
         fix Python extension compilation warning (Jan Dittberner)

diff --git a/cracklib/python/Makefile.am b/cracklib/python/Makefile.am
index c70e76d811613bb1fb791b4e7be2f3645b15d290..499ff907cceddad4de4c25c2f39da6471af6c884 100644 (file)
--- a/cracklib/python/Makefile.am
+++ b/cracklib/python/Makefile.am
@@ -1,7 +1,7 @@
 if BUILD_PYTHON
 python_PYTHON = cracklib.py
 pyexec_LTLIBRARIES = _cracklibmodule.la
-AM_CFLAGS = -I$(top_srcdir)/lib
+AM_CFLAGS = -I$(top_srcdir)/lib -Wall
 _cracklibmodule_la_LDFLAGS = -module -avoid-version $(top_builddir)/lib/libcrack.la
 DEFS += '-DDEFAULT_CRACKLIB_DICT="$(DEFAULT_CRACKLIB_DICT)"'
 DEFS += '-DPYTHON_H="python@PYTHON_VERSION@/Python.h"'

diff --git a/cracklib/python/_cracklibmodule.c b/cracklib/python/_cracklibmodule.c
index e6519e20582e02cb7a0358e274574078ef088cd9..b94825cfddc4c41f68e9e6b745dc48ae65c7e980 100644 (file)
--- a/cracklib/python/_cracklibmodule.c
+++ b/cracklib/python/_cracklibmodule.c
@@ -64,7 +64,8 @@ static char _cracklib_FascistCheck_doc [] =
 static PyObject *
 _cracklib_FascistCheck(PyObject *self, PyObject *args, PyObject *kwargs)
 {
-    char *candidate, *dict, *defaultdict;
+    char *candidate, *dict;
+    char *defaultdict = NULL;
     const char *result;
     struct stat st;
     char *keywords[] = {"pw", "dictpath", NULL};