writing type-named scrolls pr#551

entrez commented in https://github.com/NetHack/NetHack/pull/551 on Jul 16,
2021:
"When using a marker, it is possible to write a scroll based on the
 type-name assigned to it by the user. Somewhat unintuitively, this
 system broke down if the assigned name was identical to the real name of
 a scroll type: trying to write a scroll by its previously-assigned name
 'scare mon' or 'id' would be guaranteed to succeed, but this wouldn't be
 the case if the user-assigned name was 'scare monster' or 'identify'.

 Revise dowrite(write.c) to prefer a user-assigned type-name to the
 real name of a scroll that isn't already formally known, while
 continuing to prefer the real name of an identified scroll to both."

Closes #551 (Github pull request)

Also,
Closes #436 (Github issue)

diff --git a/doc/fixes3-7-0.txt b/doc/fixes3-7-0.txt
index ff70b1db9b4c04933fc02ab8cb793466f6cc590b..bf1f7d471048e271b81c40ccea175ca7e22f795a 100644 (file)
--- a/doc/fixes3-7-0.txt
+++ b/doc/fixes3-7-0.txt
@@ -1800,6 +1800,7 @@ split getting damages with a kick into separate function (pr #758 by argrath)
 split fixing curse trouble into separate function (pr #765 by argrath)
 Handle -eaux plurals in makeplural/makesingular (pr #767 by entrez)
 mdisplacem stoning and gloves had test backwards (pr #773 by entrez)
+writing type-named scrolls (pr #551 by entrez)
 
 
 Code Cleanup and Reorganization