Fixed bug #27580 (pre-initialization errors in ap2 handler are not being

written to vhost error log).
Stop using depreciated and ignored APLOG_NOERRNO directive.
Make file not found & directory as script invocation error messages more
descriptive.

diff --git a/sapi/apache2handler/sapi_apache2.c b/sapi/apache2handler/sapi_apache2.c
index 649e55c3f38954c82df8ac91e4e6b56d7cfeb5d6..ebcb6256132ddcf28b0bbf219cd7c788adde34d2 100644 (file)
--- a/sapi/apache2handler/sapi_apache2.c
+++ b/sapi/apache2handler/sapi_apache2.c
@@ -55,7 +55,7 @@
 
 /* UnixWare and Netware define shutdown to _shutdown, which causes problems later
  * on when using a structure member named shutdown. Since this source
- * file does not use the system call shutdown, it is safe to #undef it.
+ * file does not use the system call shutdown, it is safe to #undef it.K
  */
 #undef shutdown
  
@@ -283,11 +283,18 @@ static void php_apache_sapi_log_message(char *msg)
         * with Apache 1.3 -- rbb
         */
        if (ctx == NULL) { /* we haven't initialized our ctx yet, oh well */
-               ap_log_error(APLOG_MARK, APLOG_ERR | APLOG_NOERRNO | APLOG_STARTUP,
-                                        0, NULL, "%s", msg);
+               ap_log_error(APLOG_MARK, APLOG_ERR | APLOG_STARTUP, 0, NULL, "%s", msg);
        } else {
-               ap_log_rerror(APLOG_MARK, APLOG_ERR | APLOG_NOERRNO | APLOG_STARTUP,
-                                        0, ctx->r, "%s", msg);
+               ap_log_rerror(APLOG_MARK, APLOG_ERR | APLOG_STARTUP, 0, ctx->r, "%s", msg);
+       }
+}
+
+static void php_apache_sapi_log_message_ex(char *msg, request_rec *r)
+{
+       if (r) {
+               ap_log_rerror(APLOG_MARK, APLOG_ERR | APLOG_STARTUP, 0, r, msg, r->filename);
+       } else {
+               php_apache_sapi_log_message(msg);
        }
 }
 
@@ -481,14 +488,14 @@ static int php_handler(request_rec *r)
        }
 
        if (r->finfo.filetype == 0) {
-               php_apache_sapi_log_message("script not found or unable to stat");
+               php_apache_sapi_log_message_ex("script '%s' not found or unable to stat", r);
                zend_try {
                                zend_ini_deactivate(TSRMLS_C);
                } zend_end_try();
                return HTTP_NOT_FOUND;
        }
        if (r->finfo.filetype == APR_DIR) {
-               php_apache_sapi_log_message("attempt to invoke directory as script");
+               php_apache_sapi_log_message_ex("attempt to invoke directory '%s' as script", r);
                zend_try {
                        zend_ini_deactivate(TSRMLS_C);
                } zend_end_try();