]> granicus.if.org Git - sudo/commitdiff
Fix use after free in error message when a duplicate alias exists.
authorTodd C. Miller <Todd.Miller@courtesan.com>
Thu, 15 Apr 2010 10:14:41 +0000 (06:14 -0400)
committerTodd C. Miller <Todd.Miller@courtesan.com>
Thu, 15 Apr 2010 10:14:41 +0000 (06:14 -0400)
plugins/sudoers/alias.c

index 2ca8add30757fbbc5eac7056f08970b96d379a08..578c30228f3d432d0dc56111d2ee8a6b254b33b0 100644 (file)
@@ -121,8 +121,8 @@ alias_add(name, type, members)
     a->seqno = 0;
     list2tq(&a->members, members);
     if (rbinsert(aliases, a)) {
-       alias_free(a);
        snprintf(errbuf, sizeof(errbuf), "Alias `%s' already defined", name);
+       alias_free(a);
        return(errbuf);
     }
     return(NULL);