]> granicus.if.org Git - python/commitdiff
Use assertCountEqual instead of assertEqual. (#5223)
authorGregory P. Smith <greg@krypto.org>
Wed, 17 Jan 2018 22:57:57 +0000 (14:57 -0800)
committerGitHub <noreply@github.com>
Wed, 17 Jan 2018 22:57:57 +0000 (14:57 -0800)
This test doesn't care about order, the underlying filesystem APIs do not
guarantee directory listings on subsequent calls will be in the same order.

Lib/test/test_glob.py

index dce64f9fcb1a28e573b83dca74cb693d9b75fec0..767bd3764b8925fe5077879de1b0d60e93a339ff 100644 (file)
@@ -49,10 +49,10 @@ class GlobTests(unittest.TestCase):
             pattern = os.path.join(*parts)
         p = os.path.join(self.tempdir, pattern)
         res = glob.glob(p, **kwargs)
-        self.assertEqual(list(glob.iglob(p, **kwargs)), res)
+        self.assertCountEqual(glob.iglob(p, **kwargs), res)
         bres = [os.fsencode(x) for x in res]
-        self.assertEqual(glob.glob(os.fsencode(p), **kwargs), bres)
-        self.assertEqual(list(glob.iglob(os.fsencode(p), **kwargs)), bres)
+        self.assertCountEqual(glob.glob(os.fsencode(p), **kwargs), bres)
+        self.assertCountEqual(glob.iglob(os.fsencode(p), **kwargs), bres)
         return res
 
     def assertSequencesEqual_noorder(self, l1, l2):