]> granicus.if.org Git - llvm/commitdiff
SCCP - silence static analyzer dyn_cast<StructType> null dereference warning. NFCI.
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Fri, 27 Sep 2019 15:49:10 +0000 (15:49 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Fri, 27 Sep 2019 15:49:10 +0000 (15:49 +0000)
The static analyzer is warning about a potential null dereference, but we should be able to use cast<StructType> directly and if not assert will fire for us.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@373095 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Scalar/SCCP.cpp

index 0ce967c8d0b7dcbae3d5e7154ec24d67feb27164..10fbdc8aacd2fdb462d72922958d6399f4e27a3c 100644 (file)
@@ -1757,7 +1757,7 @@ static bool tryToReplaceWithConstant(SCCPSolver &Solver, Value *V) {
                      [](const LatticeVal &LV) { return LV.isOverdefined(); }))
       return false;
     std::vector<Constant *> ConstVals;
-    auto *ST = dyn_cast<StructType>(V->getType());
+    auto *ST = cast<StructType>(V->getType());
     for (unsigned i = 0, e = ST->getNumElements(); i != e; ++i) {
       LatticeVal V = IVs[i];
       ConstVals.push_back(V.isConstant()