Relevant BUGIDs:

Purpose of commit: bugfix

Commit summary:
---------------

2010-10-20  Thorsten Kukuk  <kukuk@thkukuk.de>

        * modules/pam_mkhomedir/mkhomedir_helper.c (rec_mkdir): Create
        parent directories always with mode 0755.
        (create_homedir): Create main directory with mode 0700 at first.

diff --git a/ChangeLog b/ChangeLog
index e68b86fb582e6bdd549340c971d1da2cbf701d8a..31140626504f65a4f1a24a82c71e5c8cde779c4d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-10-20  Thorsten Kukuk  <kukuk@thkukuk.de>
+
+       * modules/pam_mkhomedir/mkhomedir_helper.c (rec_mkdir): Create
+       parent directories always with mode 0755.
+       (create_homedir): Create main directory with mode 0700 at first.
+
 2010-10-19  Dmitry V. Levin  <ldv@altlinux.org>
 
        * modules/pam_selinux/Makefile.am (pam_selinux_la_LIBADD): Add

diff --git a/modules/pam_mkhomedir/mkhomedir_helper.c b/modules/pam_mkhomedir/mkhomedir_helper.c
index 550a1354cb11767feb51d5107fceeca530f75224..0ed41d6654627ecb7f6e58c218cf34b812e94f4f 100644 (file)
--- a/modules/pam_mkhomedir/mkhomedir_helper.c
+++ b/modules/pam_mkhomedir/mkhomedir_helper.c
@@ -46,7 +46,7 @@ rec_mkdir(const char *dir, mode_t mode)
 
       *cp++ = '\0';
       if (stat(parent, &st) == -1 && errno == ENOENT)
-        if (rec_mkdir(parent, mode) != 0)
+        if (rec_mkdir(parent, 0755) != 0)
          {
            free(parent);
            return 1;
@@ -72,7 +72,7 @@ create_homedir(const struct passwd *pwd,
    int retval = PAM_SESSION_ERR;
 
    /* Create the new directory */
-   if (rec_mkdir(dest, 0755) != 0)
+   if (rec_mkdir(dest, 0700) != 0)
    {
       pam_syslog(NULL, LOG_ERR, "unable to create directory %s: %m", dest);
       return PAM_PERM_DENIED;
@@ -419,4 +419,3 @@ main(int argc, char *argv[])
 
    return create_homedir(pwd, skeldir, pwd->pw_dir);
 }
-