apply -Wextra to third_party/

googletest builds cleanly with -Wextra

Remove comments about webm:1069. The vp8 issue is tracked in webm:1246.

Change-Id: I8bbb01d34503cc9c342f5c3aa78e9476f72b94c2

diff --git a/configure b/configure
index 9e349636d981949ebd462bfc222d6a5a2b516012..6204f10b6cac7158d6c0213e87e28ba6ee21a5bf 100755 (executable)
--- a/configure
+++ b/configure
@@ -614,10 +614,6 @@ process_toolchain() {
         check_add_cflags -Wimplicit-function-declaration
         check_add_cflags -Wuninitialized
         check_add_cflags -Wunused
-        # -Wextra has some tricky cases. Rather than fix them all now, get the
-        # flag for as many files as possible and fix the remaining issues
-        # piecemeal.
-        # https://bugs.chromium.org/p/webm/issues/detail?id=1069
         check_add_cflags -Wextra
         # check_add_cflags also adds to cxxflags. gtest does not do well with
         # these flags so add them explicitly to CFLAGS only.

diff --git a/libs.mk b/libs.mk
index 20aad0b4918a85b058c76eafd86644d7ab96fb23..5dfb78ff1b933f232c5bc8a5067038a8dd977a68 100644 (file)
--- a/libs.mk
+++ b/libs.mk
@@ -112,10 +112,8 @@ ifeq ($(CONFIG_DECODERS),yes)
   CODEC_DOC_SECTIONS += decoder
 endif
 
-# Suppress -Wextra warnings in third party code.
-$(BUILD_PFX)third_party/googletest/%.cc.o: CXXFLAGS += -Wno-missing-field-initializers
 # Suppress -Wextra warnings in first party code pending investigation.
-# https://bugs.chromium.org/p/webm/issues/detail?id=1069
+# https://bugs.chromium.org/p/webm/issues/detail?id=1246
 $(BUILD_PFX)vp8/encoder/onyx_if.c.o: CFLAGS += -Wno-unknown-warning-option -Wno-clobbered
 $(BUILD_PFX)vp8/decoder/onyxd_if.c.o: CFLAGS += -Wno-unknown-warning-option -Wno-clobbered