Fix race condition in CreatePipeOverlapped

fixes #10075

diff --git a/lib/base/process.cpp b/lib/base/process.cpp
index 831bf36ae1919fb826226e14b45933d63f165b91..76628cce28d82f18876ad8cc700beaa00e5dc407 100644 (file)
--- a/lib/base/process.cpp
+++ b/lib/base/process.cpp
@@ -329,13 +329,16 @@ static BOOL CreatePipeOverlapped(HANDLE *outReadPipe, HANDLE *outWritePipe,
        if (size == 0)
                size = 8192;
 
+       int currentIndex;
+
        {
                boost::mutex::scoped_lock lock(mutex);
+               currentIndex = pipeIndex;
                pipeIndex++;
        }
 
        char pipeName[128];
-       sprintf(pipeName, "\\\\.\\Pipe\\OverlappedPipe.%d.%d", (int)GetCurrentProcessId(), pipeIndex);
+       sprintf(pipeName, "\\\\.\\Pipe\\OverlappedPipe.%d.%d", (int)GetCurrentProcessId(), currentIndex);
 
        *outReadPipe = CreateNamedPipe(pipeName, PIPE_ACCESS_INBOUND | readMode,
            PIPE_TYPE_BYTE | PIPE_WAIT, 1, size, size, 60 * 1000, securityAttributes);