]> granicus.if.org Git - php/commitdiff
Don't explicitly set return value on ZPP failure in ext/xml
authorChristoph M. Becker <cmbecker69@gmx.de>
Tue, 3 Sep 2019 11:11:08 +0000 (13:11 +0200)
committerChristoph M. Becker <cmbecker69@gmx.de>
Tue, 3 Sep 2019 11:12:05 +0000 (13:12 +0200)
Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return
value is useless, and also slightly confusing.

ext/xml/xml.c

index d6e91b69ced4bebc31216ede3cc856fbaff1fbb9..4da8f54c5cd9a52e3a3608fc17237010522c156a 100644 (file)
@@ -1065,7 +1065,7 @@ static void php_xml_parser_create_impl(INTERNAL_FUNCTION_PARAMETERS, int ns_supp
        XML_Char *encoding;
 
        if (zend_parse_parameters(ZEND_NUM_ARGS(), (ns_support ? "|ss": "|s"), &encoding_param, &encoding_param_len, &ns_param, &ns_param_len) == FAILURE) {
-               RETURN_FALSE;
+               return;
        }
 
        if (encoding_param != NULL) {