(trunk) copyediting: remove some unneeded #includes, and annotate some needed ones

diff --git a/cli/cli.c b/cli/cli.c
index 9686738fbbe466c93db04672cacef69368534543..e8efb8a58b92befd751a6f747b1c4fc39991084b 100644 (file)
--- a/cli/cli.c
+++ b/cli/cli.c
@@ -22,10 +22,9 @@
  * DEALINGS IN THE SOFTWARE.
  *****************************************************************************/
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
+#include <stdio.h> /* fprintf() */
+#include <stdlib.h> /* atoi() */
+#include <string.h> /* memcmp() */
 #include <signal.h>
 
 #include <libtransmission/transmission.h>

diff --git a/daemon/daemon.c b/daemon/daemon.c
index bdffd7fdc61dda29f922e193c402be4f3b0492f5..db734cb43bffa230a982dbcdb9aa425e670d443d 100644 (file)
--- a/daemon/daemon.c
+++ b/daemon/daemon.c
@@ -13,7 +13,7 @@
 #include <errno.h>
 #include <stdio.h> /* printf */
 #include <stdlib.h> /* exit, atoi */
-#include <string.h> /* strcmp */
+#include <string.h> /* strerror() */
 
 #include <fcntl.h> /* open */
 #include <signal.h>

diff --git a/daemon/watch.c b/daemon/watch.c
index 488ef21c31a97b6bef009849d95f36f88890ef11..32e959bf67491cd12dfa142df275153cc7484e43 100644 (file)
--- a/daemon/watch.c
+++ b/daemon/watch.c
@@ -20,7 +20,7 @@
 #endif
 
 #include <errno.h>
-#include <string.h> /* strstr */
+#include <string.h> /* strlen() */
 #include <stdio.h> /* perror() */
 
 #include <dirent.h> /* readdir */

diff --git a/gtk/conf.c b/gtk/conf.c
index 2048dcf469e59077a30c7bc227d0291319d80152..19091eb4321c2a9720b475283787d5f25f74d8ce 100644 (file)
--- a/gtk/conf.c
+++ b/gtk/conf.c
@@ -24,7 +24,7 @@
 
 #include <errno.h>
 #include <stdio.h>
-#include <stdlib.h>
+#include <stdlib.h> /* strtol() */
 #include <string.h>
 
 #include <unistd.h>

diff --git a/gtk/details.c b/gtk/details.c
index 7a632fe307777de4957ea73faa8124d5203f2d7c..6eaefa1d92e8aa7872e25aab5a1aae12f4ddcb6a 100644 (file)
--- a/gtk/details.c
+++ b/gtk/details.c
@@ -10,10 +10,9 @@
  * $Id$
  */
 
-#include <assert.h>
 #include <stddef.h>
-#include <stdio.h> /* sscanf */
-#include <stdlib.h>
+#include <stdio.h> /* sscanf() */
+#include <stdlib.h> /* abort() */
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>
 

diff --git a/gtk/file-list.c b/gtk/file-list.c
index 0f60e88a1c79d66e802c3e07d5770b1999d49f92..bb24d1ad3db2b4b8958b30b6df1063ff86acb8db 100644 (file)
--- a/gtk/file-list.c
+++ b/gtk/file-list.c
@@ -12,7 +12,6 @@
 
 #include <stddef.h>
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>

diff --git a/gtk/main.c b/gtk/main.c
index 1c03a5f35c2377368cbc8c0428a4af279f656a1e..28a93b0fc2b7677eaf1df97870a1bf24fe993243 100644 (file)
--- a/gtk/main.c
+++ b/gtk/main.c
@@ -26,7 +26,7 @@
 #include <signal.h>
 #include <string.h>
 #include <stdio.h>
-#include <stdlib.h>
+#include <stdlib.h> /* exit() */
 #include <sys/param.h>
 #include <time.h>
 #include <unistd.h>

diff --git a/gtk/makemeta-ui.c b/gtk/makemeta-ui.c
index 46d14cab755be7baa517222c105d3ffec05245c2..dfa5315f5cc09f00f5aff3501b2582a0f39f3792 100644 (file)
--- a/gtk/makemeta-ui.c
+++ b/gtk/makemeta-ui.c
@@ -10,8 +10,6 @@
  * $Id$
  */
 
-#include <string.h>
-
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>
 

diff --git a/gtk/notify.c b/gtk/notify.c
index 30194b34489e9d39b96289954d864379791b0053..755d5349f508001d7135d7a4586ba5f8ccb3e53a 100644 (file)
--- a/gtk/notify.c
+++ b/gtk/notify.c
@@ -10,7 +10,7 @@
  * $Id$
  */
 
-#include <string.h>
+#include <string.h> /* strcmp() */
 
 #ifdef HAVE_LIBCANBERRA
  #include <canberra-gtk.h>

diff --git a/gtk/torrent-cell-renderer.c b/gtk/torrent-cell-renderer.c
index 895df29857523abc2f3150036614c7a4341a6fe2..82147be33912e525813fbd5e5b3c02f04f2c9e63 100644 (file)
--- a/gtk/torrent-cell-renderer.c
+++ b/gtk/torrent-cell-renderer.c
@@ -10,7 +10,6 @@
  * $Id$
  */
 
-#include <string.h> /* strcmp() */
 #include <gtk/gtk.h>
 #include <glib/gi18n.h>
 #include <libtransmission/transmission.h>

diff --git a/gtk/tr-prefs.c b/gtk/tr-prefs.c
index fd6782022d3095a651623d4a5023d063fc814ea5..e5adcff8b95416bd563cc3b62373af6c4e55584d 100644 (file)
--- a/gtk/tr-prefs.c
+++ b/gtk/tr-prefs.c
@@ -12,7 +12,7 @@
 
 #include <ctype.h> /* isspace */
 #include <limits.h> /* USHRT_MAX */
-#include <stdlib.h> /* free() */
+#include <string.h> /* strcmp() */
 #include <unistd.h>
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>

diff --git a/gtk/util.c b/gtk/util.c
index abe7d3ae8400b48f5d0fd6a910b8d08835dbfb01..dac2e6dc2a8aab529fe5c6ba9c7eb65d48d55213 100644 (file)
--- a/gtk/util.c
+++ b/gtk/util.c
@@ -13,8 +13,7 @@
 #include <ctype.h> /* isxdigit() */
 #include <errno.h>
 #include <stdarg.h>
-#include <stdlib.h> /* free() */
-#include <string.h> /* strcmp() */
+#include <string.h> /* strchr(), strrchr(), strlen(), strncmp(), strstr() */
 
 #include <sys/types.h> /* for gtr_lockfile()'s open() */
 #include <sys/stat.h> /* for gtr_lockfile()'s open() */
@@ -888,6 +887,6 @@ gtr_label_set_text( GtkLabel * lb, const char * newstr )
 {
     const char * oldstr = gtk_label_get_text( lb );
 
-    if( ( oldstr == NULL ) || strcmp( oldstr, newstr ) )
+    if( tr_strcmp0( oldstr, newstr ) )
         gtk_label_set_text( lb, newstr );
 }

diff --git a/libtransmission/JSON_parser.c b/libtransmission/JSON_parser.c
index b86e310bccbb9dfe7f264b2328af14c7395b9305..e4a5574bcf8af4a2c89619ae06b58eadf64ecf53 100644 (file)
--- a/libtransmission/JSON_parser.c
+++ b/libtransmission/JSON_parser.c
@@ -68,7 +68,6 @@ SOFTWARE.
 #include <string.h>
 #include <locale.h>
 
-#include <stdarg.h> /* some 1.4.x versions of evutil.h need this */
 #include <event2/util.h> /* evutil_strtoll() */
 
 #include "JSON_parser.h"

diff --git a/libtransmission/announcer.c b/libtransmission/announcer.c
index 1ba65dabe54d570fcba83841e797d742031f35fe..10b2d69f06ad04122a0b8c5da57e9ee234f1cb67 100644 (file)
--- a/libtransmission/announcer.c
+++ b/libtransmission/announcer.c
@@ -11,7 +11,7 @@
  */
 
 #include <assert.h>
-#include <limits.h>
+#include <limits.h> /* INT_MAX */
 #include <stdio.h>
 #include <stdlib.h> /* qsort() */
 #include <string.h> /* strcmp(), memcpy() */

diff --git a/libtransmission/blocklist-test.c b/libtransmission/blocklist-test.c
index 767e0811abf66d7cf76fa9604ccb8a7c0451a7be..fa6e656cb8d66a7c1c6e35bf54ff4558c776c84f 100644 (file)
--- a/libtransmission/blocklist-test.c
+++ b/libtransmission/blocklist-test.c
@@ -1,6 +1,4 @@
 #include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
 #include "transmission.h"
 #include "blocklist.h"
 #include "net.h"

diff --git a/libtransmission/blocklist.c b/libtransmission/blocklist.c
index dde097811540ca857d8e1eddc779a72d51ab54d9..37eae2671462a192cf53003f3a9c017e0ea007af 100644 (file)
--- a/libtransmission/blocklist.c
+++ b/libtransmission/blocklist.c
@@ -10,10 +10,14 @@
  * $Id$
  */
 
+#include <assert.h>
+#include <errno.h>
 #include <stdio.h>
-#include <stdlib.h> /* qsort(), free() */
+#include <stdlib.h> /* bsearch(), qsort() */
 #include <string.h>
 
+#include <unistd.h> /* unlink() */
+
 #ifdef WIN32
  #include <w32api.h>
  #define WINVER  WindowsXP
@@ -28,8 +32,6 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
-#include <unistd.h>
-#include <assert.h>
 
 #include "transmission.h"
 #include "platform.h"

diff --git a/libtransmission/clients-test.c b/libtransmission/clients-test.c
index 0f2ed8caa930643b58f1235de6f45ea3af9e0058..db33ebeda5c837736bfd688a54dfac8d5f0411a9 100644 (file)
--- a/libtransmission/clients-test.c
+++ b/libtransmission/clients-test.c
@@ -1,5 +1,4 @@
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 #include "transmission.h"
 #include "clients.h"

diff --git a/libtransmission/clients.c b/libtransmission/clients.c
index 484d2c351611f80f7e1f55a5e5e37ce606a26a75..75002b6d285007d5f8032704c5b75f6fed398535 100644 (file)
--- a/libtransmission/clients.c
+++ b/libtransmission/clients.c
@@ -13,7 +13,6 @@
 /* thanks amc1! */
 
 #include <ctype.h> /* isprint() */
-#include <stdio.h>
 #include <stdlib.h> /* strtol() */
 #include <string.h>
 

diff --git a/libtransmission/crypto.c b/libtransmission/crypto.c
index d40d49305c24418c69bda34c4c1394e40f688b40..36ec866654c1a7a081fb8fbed04ed4f973c28607 100644 (file)
--- a/libtransmission/crypto.c
+++ b/libtransmission/crypto.c
@@ -12,10 +12,10 @@
 
 #include <assert.h>
 #include <inttypes.h> /* uint8_t */
-#include <limits.h> /* for INT_MAX */
+#include <limits.h> /* INT_MAX */
 #include <stdarg.h>
-#include <stdlib.h> /* for abs() */
-#include <string.h> /* memcpy */
+#include <stdlib.h> /* abs() */
+#include <string.h> /* memcpy(), memset(), strcmp() */
 
 #include <openssl/bn.h>
 #include <openssl/dh.h>

diff --git a/libtransmission/fdlimit.c b/libtransmission/fdlimit.c
index 856c1d8d8de969380dd8d4119c9c51c20d943d1a..39bb2958d796f8a394acd990f989512c9ab0415b 100644 (file)
--- a/libtransmission/fdlimit.c
+++ b/libtransmission/fdlimit.c
@@ -24,8 +24,6 @@
 #include <assert.h>
 #include <errno.h>
 #include <inttypes.h>
-#include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 #ifdef SYS_DARWIN
  #include <fcntl.h>
@@ -47,7 +45,7 @@
  #include <sys/resource.h> /* getrlimit */
 #endif
 #include <fcntl.h> /* O_LARGEFILE posix_fadvise */
-#include <unistd.h>
+#include <unistd.h> /* lseek(), write(), ftruncate(), pread(), pwrite(), etc */
 
 #include "transmission.h"
 #include "fdlimit.h"

diff --git a/libtransmission/handshake.c b/libtransmission/handshake.c
index ecb0e460e56162c88467120c283c04d51ef3ff91..e670e2ffa787c0ee62ecb396f7ca5d38d9326a7a 100644 (file)
--- a/libtransmission/handshake.c
+++ b/libtransmission/handshake.c
@@ -15,7 +15,6 @@
 #include <inttypes.h>
 #include <limits.h> /* UCHAR_MAX */
 #include <string.h>
-#include <stdio.h>
 
 #include <event2/event.h>
 

diff --git a/libtransmission/inout.c b/libtransmission/inout.c
index bd4213da650800933353ac4cc75e96823c855094..5c4685579de30ce981d3798d2b29d4adf1b82603 100644 (file)
--- a/libtransmission/inout.c
+++ b/libtransmission/inout.c
@@ -12,8 +12,8 @@
 
 #include <assert.h>
 #include <errno.h>
-#include <stdlib.h> /* realloc */
-#include <string.h> /* memcmp */
+#include <stdlib.h> /* bsearch() */
+#include <string.h> /* memcmp() */
 
 #include <openssl/sha.h>
 

diff --git a/libtransmission/json.c b/libtransmission/json.c
index 6a09ebd430d53e9c9e275a0344318f0cc3cbc846..e3216a51346cd55482f45b8208abd47a8b0e03d1 100644 (file)
--- a/libtransmission/json.c
+++ b/libtransmission/json.c
@@ -13,8 +13,6 @@
 #include <assert.h>
 #include <ctype.h>
 #include <errno.h> /* EILSEQ, EINVAL */
-#include <string.h>
-#include <stdio.h> /* printf */
 
 #include "JSON_parser.h"
 

diff --git a/libtransmission/makemeta.c b/libtransmission/makemeta.c
index a3370d95957809b597ae7e870597d31d9a4ee074..8a3c4b2da2eee74617315c52505c7e4a50a5d810 100644 (file)
--- a/libtransmission/makemeta.c
+++ b/libtransmission/makemeta.c
@@ -18,7 +18,7 @@
 
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <unistd.h>
+#include <unistd.h> /* read() */
 #include <dirent.h>
 
 #include <event2/util.h> /* evutil_ascii_strcasecmp() */

diff --git a/libtransmission/net.c b/libtransmission/net.c
index ead66df6a64b1ea48bc038516fc6b0c3a93142e2..014ec899183e4f0ea3145bd6fa80212455fd2b8b 100644 (file)
--- a/libtransmission/net.c
+++ b/libtransmission/net.c
@@ -24,8 +24,6 @@
  *****************************************************************************/
 
 #include <errno.h>
-#include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 #include <assert.h>
 
@@ -40,9 +38,7 @@
  #include <netinet/tcp.h>
  #include <arpa/inet.h> /* inet_addr */
  #include <netdb.h>
- #include <fcntl.h>
 #endif
-#include <unistd.h>
 
 #include <event2/util.h>
 #include <libutp/utp.h>

diff --git a/libtransmission/peer-io.c b/libtransmission/peer-io.c
index 057e76e47e81951f4dc9a10c023c60d80d765af0..a352fa36ee618b6c88cf09faf8ebeced9c068677 100644 (file)
--- a/libtransmission/peer-io.c
+++ b/libtransmission/peer-io.c
@@ -14,8 +14,6 @@
 #include <errno.h>
 #include <limits.h> /* INT_MAX */
 #include <string.h>
-#include <stdio.h>
-#include <unistd.h>
 
 #ifdef WIN32
  #include <winsock2.h>

diff --git a/libtransmission/port-forwarding.c b/libtransmission/port-forwarding.c
index 031c8121a9155932a3dce2266fb1605fb2500481..46aa0d9fb049ab69fe296e360dac02888149767d 100644 (file)
--- a/libtransmission/port-forwarding.c
+++ b/libtransmission/port-forwarding.c
@@ -11,7 +11,6 @@
  */
 
 #include <assert.h>
-#include <string.h>
 #include <stdio.h>
 
 #include <sys/types.h>

diff --git a/libtransmission/rpc-server.c b/libtransmission/rpc-server.c
index 731181c870701d6d61f5ea2fb78a2be6d4655ec3..774e67777149647d837c101a187de981746edc9d 100644 (file)
--- a/libtransmission/rpc-server.c
+++ b/libtransmission/rpc-server.c
@@ -15,9 +15,6 @@
 #include <string.h> /* memcpy */
 #include <limits.h> /* INT_MAX */
 
-#include <sys/types.h> /* open */
-#include <sys/stat.h>  /* open */
-#include <fcntl.h>     /* open */
 #include <unistd.h>    /* close */
 
 #ifdef HAVE_ZLIB

diff --git a/libtransmission/tr-udp.c b/libtransmission/tr-udp.c
index 6797f7100dc838a19d6765d7955a720a2c9d9d94..45b7d575f0db6c9a47b2c3ebf20d6386b6eafe9f 100644 (file)
--- a/libtransmission/tr-udp.c
+++ b/libtransmission/tr-udp.c
@@ -21,11 +21,12 @@ THE SOFTWARE.
 
 */
 
-#include <unistd.h>
 #include <assert.h>
 #include <string.h> /* memcmp(), memcpy(), memset() */
 #include <stdlib.h> /* malloc(), free() */
 
+#include <unistd.h> /* close() */
+
 #include <event2/event.h>
 
 #include "transmission.h"

diff --git a/libtransmission/tr-utp.c b/libtransmission/tr-utp.c
index 71712b0d41af040576d5672b1384301dee167353..b22c3dc530175fdd23f8da51fc4a1070abedbe71 100644 (file)
--- a/libtransmission/tr-utp.c
+++ b/libtransmission/tr-utp.c
@@ -22,9 +22,9 @@ THE SOFTWARE.
 */
 
 #include <assert.h>
-#include <unistd.h>
 
 #include <event2/event.h>
+
 #include <libutp/utp.h>
 
 #include "transmission.h"

diff --git a/libtransmission/trevent.c b/libtransmission/trevent.c
index a72496dd5132f1140e6e3f0b55ff7b35ad1afa35..1aeb4961ba39884d90dbdd73174edeaba9598a45 100644 (file)
--- a/libtransmission/trevent.c
+++ b/libtransmission/trevent.c
@@ -12,9 +12,7 @@
 
 #include <assert.h>
 #include <errno.h>
-#include <stdlib.h>
 #include <string.h>
-#include <stdio.h>
 
 #include <signal.h>
 
@@ -125,7 +123,7 @@ piperead( int s, char *buf, int len )
 #define pipewrite(a,b,c) write(a,b,c)
 #endif
 
-#include <unistd.h>
+#include <unistd.h> /* read(), write(), pipe() */
 
 #include "transmission.h"
 #include "platform.h"

diff --git a/libtransmission/utils.c b/libtransmission/utils.c
index a5237e5eb7836345c5a008201a0632e6aad8b869..9511142ce823eef0069a65f470dc425e5babe327 100644 (file)
--- a/libtransmission/utils.c
+++ b/libtransmission/utils.c
@@ -22,7 +22,7 @@
 #endif
 
 #include <assert.h>
-#include <ctype.h> /* isalpha(), tolower() */
+#include <ctype.h> /* isdigit(), isalpha(), tolower() */
 #include <errno.h>
 #include <float.h> /* DBL_EPSILON */
 #include <locale.h> /* localeconv() */
@@ -40,7 +40,7 @@
 #include <sys/time.h>
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <unistd.h> /* stat(), getcwd(), getpagesize() */
+#include <unistd.h> /* stat(), getcwd(), getpagesize(), unlink() */
 
 #include <event2/buffer.h>
 #include <event2/event.h>