]> granicus.if.org Git - php/commitdiff
move plugin specific stuff to one file. create object factory
authorAndrey Hristov <andrey@php.net>
Mon, 24 Oct 2011 12:34:44 +0000 (12:34 +0000)
committerAndrey Hristov <andrey@php.net>
Mon, 24 Oct 2011 12:34:44 +0000 (12:34 +0000)
for similar objects

ext/mysqlnd/mysqlnd.c
ext/mysqlnd/mysqlnd_driver.c
ext/mysqlnd/mysqlnd_net.c
ext/mysqlnd/mysqlnd_priv.h
ext/mysqlnd/mysqlnd_ps.c
ext/mysqlnd/mysqlnd_structs.h
ext/mysqlnd/mysqlnd_wireprotocol.c

index d374a0d6cc09d6b8d6da7eaca1faad38dedc1b21..ecb19e2dbe3486f608d7c78109fc5d1176c3b7df 100644 (file)
@@ -63,22 +63,6 @@ PHPAPI const char * const mysqlnd_out_of_memory = "Out of memory";
 
 PHPAPI MYSQLND_STATS *mysqlnd_global_stats = NULL;
 
-static struct st_mysqlnd_plugin_core mysqlnd_plugin_core;
-
-/* {{{ mysqlnd_error_list_pdtor */
-static void
-mysqlnd_error_list_pdtor(void * pDest)
-{
-       MYSQLND_ERROR_LIST_ELEMENT * element = (MYSQLND_ERROR_LIST_ELEMENT *) pDest;
-       TSRMLS_FETCH();
-       DBG_ENTER("mysqlnd_error_list_pdtor");
-       if (element->error) {
-               mnd_pefree(element->error, TRUE);
-       }
-       DBG_VOID_RETURN;
-}
-/* }}} */
-
 /* {{{ mysqlnd_conn::free_options */
 static void
 MYSQLND_METHOD(mysqlnd_conn, free_options)(MYSQLND * conn TSRMLS_DC)
@@ -2470,37 +2454,13 @@ MYSQLND_CLASS_METHODS_START(mysqlnd_conn)
 MYSQLND_CLASS_METHODS_END;
 
 
-/* {{{ mysqlnd_init */
-PHPAPI MYSQLND * _mysqlnd_init(zend_bool persistent TSRMLS_DC)
+/* {{{ _mysqlnd_init */
+PHPAPI MYSQLND *
+_mysqlnd_init(zend_bool persistent TSRMLS_DC)
 {
-       size_t alloc_size = sizeof(MYSQLND) + mysqlnd_plugin_count() * sizeof(void *);
-       MYSQLND *ret;
-
+       MYSQLND * ret;
        DBG_ENTER("mysqlnd_init");
-       DBG_INF_FMT("persistent=%u", persistent);
-       ret = mnd_pecalloc(1, alloc_size, persistent);
-       if (!ret) {
-               DBG_RETURN(NULL);
-       }
-
-       ret->persistent = persistent;
-       ret->m = mysqlnd_conn_get_methods();
-       CONN_SET_STATE(ret, CONN_ALLOCED);
-       ret->m->get_reference(ret TSRMLS_CC);
-
-       if (PASS != ret->m->init(ret TSRMLS_CC)) {
-               ret->m->dtor(ret TSRMLS_CC);
-               ret = NULL;
-       }
-
-       ret->error_info.error_list = mnd_pecalloc(1, sizeof(zend_llist), persistent);
-       if (!ret->error_info.error_list) {
-               ret->m->dtor(ret TSRMLS_CC);
-               ret = NULL;
-       } else {
-               zend_llist_init(ret->error_info.error_list, sizeof(MYSQLND_ERROR_LIST_ELEMENT), (llist_dtor_func_t)mysqlnd_error_list_pdtor, persistent);
-       }
-
+       ret = MYSQLND_CLASS_METHOD_TABLE_NAME(mysqlnd_object_factory).get_connection(persistent TSRMLS_CC);
        DBG_RETURN(ret);
 }
 /* }}} */
index c2acf89d606050810dd47cd3d348e27d53cd1d5c..2f015374c55e08a0f89946832668a65ebf47584f 100644 (file)
@@ -90,6 +90,163 @@ PHPAPI void mysqlnd_library_init(TSRMLS_D)
 /* }}} */
 
 
+
+/* {{{ mysqlnd_error_list_pdtor */
+static void
+mysqlnd_error_list_pdtor(void * pDest)
+{
+       MYSQLND_ERROR_LIST_ELEMENT * element = (MYSQLND_ERROR_LIST_ELEMENT *) pDest;
+       TSRMLS_FETCH();
+       DBG_ENTER("mysqlnd_error_list_pdtor");
+       if (element->error) {
+               mnd_pefree(element->error, TRUE);
+       }
+       DBG_VOID_RETURN;
+}
+/* }}} */
+
+
+/* {{{ mysqlnd_object_factory::get_connection */
+static MYSQLND *
+MYSQLND_METHOD(mysqlnd_object_factory, get_connection)(zend_bool persistent TSRMLS_DC)
+{
+       size_t alloc_size = sizeof(MYSQLND) + mysqlnd_plugin_count() * sizeof(void *);
+       MYSQLND *ret;
+
+       DBG_ENTER("mysqlnd_driver::get_connection");
+       DBG_INF_FMT("persistent=%u", persistent);
+       ret = mnd_pecalloc(1, alloc_size, persistent);
+       if (!ret) {
+               DBG_RETURN(NULL);
+       }
+
+       ret->persistent = persistent;
+       ret->m = mysqlnd_conn_get_methods();
+       CONN_SET_STATE(ret, CONN_ALLOCED);
+       ret->m->get_reference(ret TSRMLS_CC);
+
+       if (PASS != ret->m->init(ret TSRMLS_CC)) {
+               ret->m->dtor(ret TSRMLS_CC);
+               ret = NULL;
+       }
+
+       ret->error_info.error_list = mnd_pecalloc(1, sizeof(zend_llist), persistent);
+       if (!ret->error_info.error_list) {
+               ret->m->dtor(ret TSRMLS_CC);
+               ret = NULL;
+       } else {
+               zend_llist_init(ret->error_info.error_list, sizeof(MYSQLND_ERROR_LIST_ELEMENT), (llist_dtor_func_t)mysqlnd_error_list_pdtor, persistent);
+       }
+
+       DBG_RETURN(ret);
+}
+/* }}} */
+
+
+/* {{{ mysqlnd_object_factory::get_prepared_statement */
+static MYSQLND_STMT *
+MYSQLND_METHOD(mysqlnd_object_factory, get_prepared_statement)(MYSQLND * const conn TSRMLS_DC)
+{
+       size_t alloc_size = sizeof(MYSQLND_STMT) + mysqlnd_plugin_count() * sizeof(void *);
+       MYSQLND_STMT * ret = mnd_pecalloc(1, alloc_size, conn->persistent);
+       MYSQLND_STMT_DATA * stmt = NULL;
+
+       DBG_ENTER("mysqlnd_object_factory::get_prepared_statement");
+       do {
+               if (!ret) {
+                       break;
+               }
+               ret->m = mysqlnd_stmt_get_methods();
+               ret->persistent = conn->persistent;
+
+               stmt = ret->data = mnd_pecalloc(1, sizeof(MYSQLND_STMT_DATA), conn->persistent);
+               DBG_INF_FMT("stmt=%p", stmt);
+               if (!stmt) {
+                       break;
+               }
+               stmt->persistent = conn->persistent;
+               stmt->state = MYSQLND_STMT_INITTED;
+               stmt->execute_cmd_buffer.length = 4096;
+               stmt->execute_cmd_buffer.buffer = mnd_pemalloc(stmt->execute_cmd_buffer.length, stmt->persistent);
+               if (!stmt->execute_cmd_buffer.buffer) {
+                       break;
+               }
+
+               stmt->prefetch_rows = MYSQLND_DEFAULT_PREFETCH_ROWS;
+               /*
+                 Mark that we reference the connection, thus it won't be
+                 be destructed till there is open statements. The last statement
+                 or normal query result will close it then.
+               */
+               stmt->conn = conn->m->get_reference(conn TSRMLS_CC);
+               stmt->error_info.error_list = mnd_pecalloc(1, sizeof(zend_llist), ret->persistent);
+               if (!stmt->error_info.error_list) {
+                       break;
+               }
+               zend_llist_init(stmt->error_info.error_list, sizeof(MYSQLND_ERROR_LIST_ELEMENT), (llist_dtor_func_t) mysqlnd_error_list_pdtor, conn->persistent);
+
+               DBG_RETURN(ret);
+       } while (0);
+
+       SET_OOM_ERROR(conn->error_info);
+       if (ret) {
+               ret->m->dtor(ret, TRUE TSRMLS_CC);
+               ret = NULL;
+       }
+       DBG_RETURN(NULL);
+}
+/* }}} */
+
+
+/* {{{ mysqlnd_object_factory::get_io_channel */
+PHPAPI MYSQLND_NET *
+MYSQLND_METHOD(mysqlnd_object_factory, get_io_channel)(zend_bool persistent, MYSQLND_STATS * stats, MYSQLND_ERROR_INFO * error_info TSRMLS_DC)
+{
+       size_t alloc_size = sizeof(MYSQLND_NET) + mysqlnd_plugin_count() * sizeof(void *);
+       MYSQLND_NET * net = mnd_pecalloc(1, alloc_size, persistent);
+
+       DBG_ENTER("mysqlnd_object_factory::get_io_channel");
+       DBG_INF_FMT("persistent=%u", persistent);
+       if (net) {
+               net->persistent = persistent;
+               net->m = *mysqlnd_net_get_methods();
+
+               if (PASS != net->m.init(net, stats, error_info TSRMLS_CC)) {
+                       net->m.dtor(net, stats, error_info TSRMLS_CC);
+                       net = NULL;
+               }
+       }
+       DBG_RETURN(net);
+}
+/* }}} */
+
+
+/* {{{ mysqlnd_object_factory::get_protocol_decoder */
+PHPAPI MYSQLND_PROTOCOL *
+MYSQLND_METHOD(mysqlnd_object_factory, get_protocol_decoder)(zend_bool persistent TSRMLS_DC)
+{
+       size_t alloc_size = sizeof(MYSQLND_PROTOCOL) + mysqlnd_plugin_count() * sizeof(void *);
+       MYSQLND_PROTOCOL *ret = mnd_pecalloc(1, alloc_size, persistent);
+
+       DBG_ENTER("mysqlnd_object_factory::get_protocol_decoder");
+       DBG_INF_FMT("persistent=%u", persistent);
+       if (ret) {
+               ret->persistent = persistent;
+               ret->m = mysqlnd_mysqlnd_protocol_methods;
+       }
+
+       DBG_RETURN(ret);
+}
+/* }}} */
+
+
+MYSQLND_CLASS_METHODS_START(mysqlnd_object_factory)
+       MYSQLND_METHOD(mysqlnd_object_factory, get_connection),
+       MYSQLND_METHOD(mysqlnd_object_factory, get_prepared_statement),
+       MYSQLND_METHOD(mysqlnd_object_factory, get_io_channel),
+       MYSQLND_METHOD(mysqlnd_object_factory, get_protocol_decoder)
+MYSQLND_CLASS_METHODS_END;
+
 /*
  * Local variables:
  * tab-width: 4
index e36c3e80203a20fb32936e8f352983ed632be41f..fb4c2f2fe56611468fc0091bd5437bd95df663d4 100644 (file)
@@ -1037,20 +1037,9 @@ MYSQLND_CLASS_METHODS_END;
 PHPAPI MYSQLND_NET *
 mysqlnd_net_init(zend_bool persistent, MYSQLND_STATS * stats, MYSQLND_ERROR_INFO * error_info TSRMLS_DC)
 {
-       size_t alloc_size = sizeof(MYSQLND_NET) + mysqlnd_plugin_count() * sizeof(void *);
-       MYSQLND_NET * net = mnd_pecalloc(1, alloc_size, persistent);
-
+       MYSQLND_NET * net;
        DBG_ENTER("mysqlnd_net_init");
-       DBG_INF_FMT("persistent=%u", persistent);
-       if (net) {
-               net->persistent = persistent;
-               net->m = *mysqlnd_net_get_methods();
-
-               if (PASS != net->m.init(net, stats, error_info TSRMLS_CC)) {
-                       net->m.dtor(net, stats, error_info TSRMLS_CC);
-                       net = NULL;
-               }
-       }
+       net = MYSQLND_CLASS_METHOD_TABLE_NAME(mysqlnd_object_factory).get_io_channel(persistent, stats, error_info TSRMLS_CC);
        DBG_RETURN(net);
 }
 /* }}} */
index a069adced375bc5f26beb932c684ce905c9242ee..a5e72eca44c8f1ec2d00ab1d44f2a52396a52efd 100644 (file)
 #define pestrndup(s, length, persistent) ((persistent)?zend_strndup((s),(length)):estrndup((s),(length)))
 #endif
 
-#define MYSQLND_CLASS_METHOD_TABLE_NAME(class) mysqlnd_##class##_methods
-#define MYSQLND_CLASS_METHODS_START(class)     MYSQLND_CLASS_METHOD_TABLE_NAME_FORWARD(class) = {
-#define MYSQLND_CLASS_METHODS_END                      }
-#define MYSQLND_CLASS_METHOD_TABLE_NAME_FORWARD(class) struct st_##class##_methods MYSQLND_CLASS_METHOD_TABLE_NAME(class)
-
 #if MYSQLND_UNICODE
 #define mysqlnd_array_init(arg, field_count) \
 { \
@@ -205,6 +200,7 @@ PHPAPI extern const char * const mysqlnd_out_of_sync;
 PHPAPI extern const char * const mysqlnd_server_gone;
 PHPAPI extern const char * const mysqlnd_out_of_memory;
 
+extern MYSQLND_CLASS_METHOD_TABLE_NAME_FORWARD(mysqlnd_object_factory);
 extern MYSQLND_CLASS_METHOD_TABLE_NAME_FORWARD(mysqlnd_conn);
 extern MYSQLND_CLASS_METHOD_TABLE_NAME_FORWARD(mysqlnd_res);
 extern MYSQLND_CLASS_METHOD_TABLE_NAME_FORWARD(mysqlnd_protocol);
index 91c4a7c24d288e01b76b8c55d1ce14ca4a65eb75..eff2367d1f76f71cc39fb75bf74595f77afe4a5f 100644 (file)
@@ -51,21 +51,6 @@ static void mysqlnd_stmt_separate_result_bind(MYSQLND_STMT * const stmt TSRMLS_D
 static void mysqlnd_stmt_separate_one_result_bind(MYSQLND_STMT * const stmt, unsigned int param_no TSRMLS_DC);
 
 
-/* {{{ mysqlnd_ps_error_list_pdtor */
-static void
-mysqlnd_ps_error_list_pdtor(void * pDest)
-{
-       MYSQLND_ERROR_LIST_ELEMENT * element = (MYSQLND_ERROR_LIST_ELEMENT *) pDest;
-       TSRMLS_FETCH();
-       DBG_ENTER("mysqlnd_ps_error_list_pdtor");
-       if (element->error) {
-               mnd_pefree(element->error, TRUE);
-       }
-       DBG_VOID_RETURN;
-}
-/* }}} */
-
-
 /* {{{ mysqlnd_stmt::store_result */
 static MYSQLND_RES *
 MYSQLND_METHOD(mysqlnd_stmt, store_result)(MYSQLND_STMT * const s TSRMLS_DC)
@@ -2362,55 +2347,13 @@ MYSQLND_CLASS_METHODS_END;
 
 
 /* {{{ _mysqlnd_stmt_init */
-MYSQLND_STMT * _mysqlnd_stmt_init(MYSQLND * const conn TSRMLS_DC)
+MYSQLND_STMT *
+_mysqlnd_stmt_init(MYSQLND * const conn TSRMLS_DC)
 {
-       size_t alloc_size = sizeof(MYSQLND_STMT) + mysqlnd_plugin_count() * sizeof(void *);
-       MYSQLND_STMT * ret = mnd_pecalloc(1, alloc_size, conn->persistent);
-       MYSQLND_STMT_DATA * stmt = NULL;
-
+       MYSQLND_STMT * ret;
        DBG_ENTER("_mysqlnd_stmt_init");
-       do {
-               if (!ret) {
-                       break;
-               }
-               ret->m = mysqlnd_stmt_get_methods();
-               ret->persistent = conn->persistent;
-
-               stmt = ret->data = mnd_pecalloc(1, sizeof(MYSQLND_STMT_DATA), conn->persistent);
-               DBG_INF_FMT("stmt=%p", stmt);
-               if (!stmt) {
-                       break;
-               }
-               stmt->persistent = conn->persistent;
-               stmt->state = MYSQLND_STMT_INITTED;
-               stmt->execute_cmd_buffer.length = 4096;
-               stmt->execute_cmd_buffer.buffer = mnd_pemalloc(stmt->execute_cmd_buffer.length, stmt->persistent);
-               if (!stmt->execute_cmd_buffer.buffer) {
-                       break;
-               }
-
-               stmt->prefetch_rows = MYSQLND_DEFAULT_PREFETCH_ROWS;
-               /*
-                 Mark that we reference the connection, thus it won't be
-                 be destructed till there is open statements. The last statement
-                 or normal query result will close it then.
-               */
-               stmt->conn = conn->m->get_reference(conn TSRMLS_CC);
-               stmt->error_info.error_list = mnd_pecalloc(1, sizeof(zend_llist), ret->persistent);
-               if (!stmt->error_info.error_list) {
-                       break;
-               }
-               zend_llist_init(stmt->error_info.error_list, sizeof(MYSQLND_ERROR_LIST_ELEMENT), (llist_dtor_func_t) mysqlnd_ps_error_list_pdtor, conn->persistent);
-
-               DBG_RETURN(ret);
-       } while (0);
-
-       SET_OOM_ERROR(conn->error_info);
-       if (ret) {
-               ret->m->dtor(ret, TRUE TSRMLS_CC);
-               ret = NULL;
-       }
-       DBG_RETURN(NULL);
+       ret = MYSQLND_CLASS_METHOD_TABLE_NAME(mysqlnd_object_factory).get_prepared_statement(conn TSRMLS_CC);
+       DBG_RETURN(ret);
 }
 /* }}} */
 
index e681c897cef4a8681116ebc27b163a9169151ae1..8fb8c4802237d7d4534dcb1362fd0176ef964605 100644 (file)
 
 #define MYSQLND_TYPEDEFED_METHODS
 
+#define MYSQLND_CLASS_METHOD_TABLE_NAME(class) mysqlnd_##class##_methods
+#define MYSQLND_CLASS_METHOD_TABLE_NAME_FORWARD(class) struct st_##class##_methods MYSQLND_CLASS_METHOD_TABLE_NAME(class)
+
+#define MYSQLND_CLASS_METHODS_START(class)     MYSQLND_CLASS_METHOD_TABLE_NAME_FORWARD(class) = {
+#define MYSQLND_CLASS_METHODS_END                      }
+
 typedef struct st_mysqlnd_memory_pool MYSQLND_MEMORY_POOL;
 typedef struct st_mysqlnd_memory_pool_chunk MYSQLND_MEMORY_POOL_CHUNK;
 typedef struct st_mysqlnd_memory_pool_chunk_llist MYSQLND_MEMORY_POOL_CHUNK_LLIST;
@@ -367,6 +373,21 @@ struct st_mysqlnd_protocol_methods
 };
 
 
+typedef MYSQLND * (*func_mysqlnd_object_factory__get_connection)(zend_bool persistent TSRMLS_DC);
+typedef MYSQLND_STMT * (*func_mysqlnd_object_factory__get_prepared_statement)(MYSQLND * conn TSRMLS_DC);
+typedef MYSQLND_NET * (*func_mysqlnd_object_factory__get_io_channel)(zend_bool persistent, MYSQLND_STATS * stats, MYSQLND_ERROR_INFO * error_info TSRMLS_DC);
+typedef MYSQLND_PROTOCOL * (*func_mysqlnd_object_factory__get_protocol_decoder)(zend_bool persistent TSRMLS_DC);
+
+
+struct st_mysqlnd_object_factory_methods
+{
+       func_mysqlnd_object_factory__get_connection get_connection;
+       func_mysqlnd_object_factory__get_prepared_statement get_prepared_statement;
+       func_mysqlnd_object_factory__get_io_channel get_io_channel;
+       func_mysqlnd_object_factory__get_protocol_decoder get_protocol_decoder;
+};
+
+
 typedef enum_func_status       (*func_mysqlnd_conn__init)(MYSQLND * conn TSRMLS_DC);
 typedef enum_func_status       (*func_mysqlnd_conn__connect)(MYSQLND *conn, const char *host, const char * user, const char * passwd, unsigned int passwd_len, const char * db, unsigned int db_len, unsigned int port, const char * socket_or_pipe, unsigned int mysql_flags TSRMLS_DC);
 typedef ulong                          (*func_mysqlnd_conn__escape_string)(MYSQLND * const conn, char *newstr, const char *escapestr, size_t escapestr_len TSRMLS_DC);
index 751474dc3252736f6c0695ccebb5137bd03abe93..85cc4d1af193fa4e5f9625038a5932b730480446 100644 (file)
@@ -2371,16 +2371,9 @@ MYSQLND_CLASS_METHODS_END;
 PHPAPI MYSQLND_PROTOCOL *
 mysqlnd_protocol_init(zend_bool persistent TSRMLS_DC)
 {
-       size_t alloc_size = sizeof(MYSQLND_PROTOCOL) + mysqlnd_plugin_count() * sizeof(void *);
-       MYSQLND_PROTOCOL *ret = mnd_pecalloc(1, alloc_size, persistent);
-
+       MYSQLND_PROTOCOL * ret;
        DBG_ENTER("mysqlnd_protocol_init");
-       DBG_INF_FMT("persistent=%u", persistent);
-       if (ret) {
-               ret->persistent = persistent;
-               ret->m = mysqlnd_mysqlnd_protocol_methods;
-       }
-
+       ret = MYSQLND_CLASS_METHOD_TABLE_NAME(mysqlnd_object_factory).get_protocol_decoder(persistent TSRMLS_CC);
        DBG_RETURN(ret);
 }
 /* }}} */