Return FALSE on error as mentioned by John Coggeshall.

See Bug #20822

diff --git a/ext/standard/image.c b/ext/standard/image.c
index 6de174cad8f3022f9d9b8b08dc11fdf534a9d6e6..92cab3654e586c7aa8a3b4959f5b35ee7a95668f 100644 (file)
--- a/ext/standard/image.c
+++ b/ext/standard/image.c
@@ -825,6 +825,7 @@ PHP_FUNCTION(image_type_to_mime_type)
        int arg_c = ZEND_NUM_ARGS();
 
        if ((arg_c!=1) || zend_get_parameters_ex(arg_c, &p_image_type) == FAILURE) {
+               RETVAL_FALSE;
                WRONG_PARAM_COUNT;
        }
        convert_to_long_ex(p_image_type);
@@ -896,6 +897,7 @@ PHP_FUNCTION(getimagesize)
 
        case 1:
                if (zend_get_parameters_ex(1, &arg1) == FAILURE) {
+                       RETVAL_FALSE;
                        WRONG_PARAM_COUNT;
                }
                convert_to_string_ex(arg1);
@@ -903,20 +905,21 @@ PHP_FUNCTION(getimagesize)
 
        case 2:
                if (zend_get_parameters_ex(2, &arg1, &info) == FAILURE) {
+                       RETVAL_FALSE;
                        WRONG_PARAM_COUNT;
                }
                zval_dtor(*info);
 
                if (array_init(*info) == FAILURE) {
-                       return;
+                       RETURN_FALSE;
                }
 
                convert_to_string_ex(arg1);
                break;
 
        default:
+               RETVAL_FALSE;
                WRONG_PARAM_COUNT;
-               break;
        }
 
        stream = php_stream_open_wrapper(Z_STRVAL_PP(arg1), "rb", REPORT_ERRORS|IGNORE_PATH|ENFORCE_SAFE_MODE, NULL);
@@ -976,7 +979,7 @@ PHP_FUNCTION(getimagesize)
                if (array_init(return_value) == FAILURE) {
                        php_error_docref(NULL TSRMLS_CC, E_ERROR, "Unable to initialize array");
                        efree(result);
-                       return;
+                       RETURN_FALSE;
                }
                add_index_long(return_value, 0, result->width);
                add_index_long(return_value, 1, result->height);