Fix smoke test on MSVC

The MSVC-generated code in debug mode was (quite rightly) complaining
about iterating past the start of an empty vector, and aborting the
test.

diff --git a/test_drivers/smoke_test/test.cpp b/test_drivers/smoke_test/test.cpp
index d7bc4268ede24bd0ae6d6be59f252b45cd0d5b47..4f9fb0485068d8bbd7a9f686947ee3e96e03e67d 100644 (file)
--- a/test_drivers/smoke_test/test.cpp
+++ b/test_drivers/smoke_test/test.cpp
@@ -154,10 +154,11 @@ int main()
     //replace_invalid
     char invalid_sequence[] = "a\x80\xe0\xa0\xc0\xaf\xed\xa0\x80z";
     vector<char> replace_invalid_result;
-    replace_invalid (invalid_sequence, invalid_sequence + sizeof(invalid_sequence), replace_invalid_result.begin(), '?');
+    replace_invalid (invalid_sequence, invalid_sequence + sizeof(invalid_sequence), std::back_inserter(replace_invalid_result), '?');
     bvalid = is_valid(replace_invalid_result.begin(), replace_invalid_result.end());
     assert (bvalid);
-    const char* fixed_invalid_sequence = "a????z";
+    const char fixed_invalid_sequence[] = "a????z";
+    assert (sizeof(fixed_invalid_sequence) == replace_invalid_result.size());
     assert (std::equal(replace_invalid_result.begin(), replace_invalid_result.begin() + sizeof(fixed_invalid_sequence), fixed_invalid_sequence));
 
     // iterator