Possible segfault in file2strvec introduced by latest CVE fix

'rbuf' used before allocated.
Revealed by static analysis

diff --git a/proc/readproc.c b/proc/readproc.c
index a6666cbca9ca7c68887b70f8f9b140d0779da651..544592534045fa4d7b55ed84c69b027da0f5f111 100644 (file)
--- a/proc/readproc.c
+++ b/proc/readproc.c
@@ -720,7 +720,7 @@ static char** file2strvec(const char* directory, const char* what) {
        #undef ARG_LEN
        if (end_of_file &&
            ((n > 0 && buf[n-1] != '\0') ||     /* last read char not null */
-            (n <= 0 && rbuf[tot-1] != '\0')))  /* last read char not null */
+            (n <= 0 && rbuf && rbuf[tot-1] != '\0')))  /* last read char not null */
            buf[n++] = '\0';                    /* so append null-terminator */
 
        if (n <= 0) break; /* unneeded (end_of_file = 1) but avoid realloc */