]> granicus.if.org Git - php/commitdiff
Remove unnecessary boundary checks
authorThomas Punt <tpunt@hotmail.co.uk>
Sat, 16 Apr 2016 08:33:01 +0000 (09:33 +0100)
committerAnatol Belski <ab@php.net>
Mon, 16 May 2016 17:15:40 +0000 (19:15 +0200)
ext/standard/array.c

index 0800ac017ca3304b8bdfed67233b5b58a2d676ec..82b1d5ae20394f62fcf4b065709cc4f3f30814f0 100644 (file)
@@ -2237,7 +2237,7 @@ double_str:
                        RANGE_CHECK_DOUBLE_INIT_ARRAY(low, high);
 
                        ZEND_HASH_FILL_PACKED(Z_ARRVAL_P(return_value)) {
-                               for (i = 0; i < size && (element = low - (i * step)) <= low && element >= high; ++i) {
+                               for (i = 0; i < size && (element = low - (i * step)) >= high; ++i) {
                                        Z_DVAL(tmp) = element;
                                        ZEND_HASH_FILL_ADD(&tmp);
                                }
@@ -2251,7 +2251,7 @@ double_str:
                        RANGE_CHECK_DOUBLE_INIT_ARRAY(high, low);
 
                        ZEND_HASH_FILL_PACKED(Z_ARRVAL_P(return_value)) {
-                               for (i = 0; i < size && (element = low + (i * step)) <= high && element >= low; ++i) {
+                               for (i = 0; i < size && (element = low + (i * step)) <= high; ++i) {
                                        Z_DVAL(tmp) = element;
                                        ZEND_HASH_FILL_ADD(&tmp);
                                }