When writing a PCH file, write multiple type and declaration blocks as

necessary and iterate until all types and declarations have been
written. This reduces the Cocoa.h PCH file size by about 4% (since we
don't write types we don't need), and fixes problems where writing a
declaration generates a new type.

This doesn't seem to have any impact on performance either way.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@70109 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/clang/Frontend/PCHWriter.h b/include/clang/Frontend/PCHWriter.h
index 034c1afb286288214f4e3d7e2236093e912bcf47..a26d944811b06e64c6e7f23e82a640706a81ffe6 100644 (file)
--- a/include/clang/Frontend/PCHWriter.h
+++ b/include/clang/Frontend/PCHWriter.h
@@ -86,6 +86,10 @@ private:
   /// \brief The type ID that will be assigned to the next new type.
   pch::TypeID NextTypeID;
 
+  /// \brief Queue containing the types that we still need to
+  /// emit.
+  std::queue<const Type *> TypesToEmit;
+
   /// \brief Map that provides the ID numbers of each identifier in
   /// the output stream.
   ///

diff --git a/lib/Frontend/PCHReader.cpp b/lib/Frontend/PCHReader.cpp
index 9970eb2b0905617ab9f6da0bccc1bbcbb006671f..0407ed899684b7906d0d43d8712241f9ab8fcb33 100644 (file)
--- a/lib/Frontend/PCHReader.cpp
+++ b/lib/Frontend/PCHReader.cpp
@@ -2563,6 +2563,7 @@ QualType PCHReader::GetType(pch::TypeID ID) {
   }
 
   Index -= pch::NUM_PREDEF_TYPE_IDS;
+  assert(Index < TypesLoaded.size() && "Type index out-of-range");
   if (!TypesLoaded[Index])
     TypesLoaded[Index] = ReadTypeRecord(TypeOffsets[Index]).getTypePtr();
     

diff --git a/lib/Frontend/PCHWriter.cpp b/lib/Frontend/PCHWriter.cpp
index 9056f58c6ff982649e50dd9664149722e87a0fc7..a43e59961a5a74a1e3dde370fa25f1414763a4dd 100644 (file)
--- a/lib/Frontend/PCHWriter.cpp
+++ b/lib/Frontend/PCHWriter.cpp
@@ -1674,15 +1674,12 @@ void PCHWriter::WriteTypesBlock(ASTContext &Context) {
   // Enter the types block.
   Stream.EnterSubblock(pch::TYPES_BLOCK_ID, 2);
 
-  // Emit all of the types in the ASTContext
-  for (std::vector<Type*>::const_iterator T = Context.getTypes().begin(),
-                                       TEnd = Context.getTypes().end();
-       T != TEnd; ++T) {
-    // Builtin types are never serialized.
-    if (isa<BuiltinType>(*T))
-      continue;
-
-    WriteType(*T);
+  // Emit all of the types that need to be emitted (so far).
+  while (!TypesToEmit.empty()) {
+    const Type *T = TypesToEmit.front();
+    TypesToEmit.pop();
+    assert(!isa<BuiltinType>(T) && "Built-in types are not serialized");
+    WriteType(T);
   }
 
   // Exit the types block
@@ -2409,8 +2406,16 @@ void PCHWriter::WritePCH(Sema &SemaRef) {
   WriteLanguageOptions(Context.getLangOptions());
   WriteSourceManagerBlock(Context.getSourceManager(), PP);
   WritePreprocessor(PP);
-  WriteTypesBlock(Context);
-  WriteDeclsBlock(Context);
+
+  // Keep writing types and declarations until all types and
+  // declarations have been written.
+  do {
+    if (!DeclsToEmit.empty())
+      WriteDeclsBlock(Context);
+    if (!TypesToEmit.empty())
+      WriteTypesBlock(Context);
+  } while (!(DeclsToEmit.empty() && TypesToEmit.empty()));
+
   WriteMethodPool(SemaRef);
   WriteIdentifierTable(PP);
 
@@ -2559,8 +2564,12 @@ void PCHWriter::AddTypeRef(QualType T, RecordData &Record) {
   }
 
   pch::TypeID &ID = TypeIDs[T.getTypePtr()];
-  if (ID == 0) // we haven't seen this type before
+  if (ID == 0) {
+    // We haven't seen this type before. Assign it a new ID and put it
+    // into the queu of types to emit.
     ID = NextTypeID++;
+    TypesToEmit.push(T.getTypePtr());
+  }
 
   // Encode the type qualifiers in the type reference.
   Record.push_back((ID << 3) | T.getCVRQualifiers());