Declare mkdtemp() only if we're providing it.

Follow our usual style of providing an "extern" for a standard library
function only when we're also providing the implementation.  This avoids
issues when the system headers declare the function slightly differently
than we do, as noted by Caleb Welton.

We might have to go to the extent of probing to see if the system headers
declare the function, but let's not do that until it's demonstrated to be
necessary.

Oversight in commit 9e6b1bf258170e62dac555fc82ff0536dfe01d29.  Back-patch
to all supported branches, as that was.

diff --git a/src/include/port.h b/src/include/port.h
index 2d1a427eaba44929c964406ace9ad5dad8208e8b..01fd9cf61dc2a84b3d37929bfe9c015be2d84cd9 100644 (file)
--- a/src/include/port.h
+++ b/src/include/port.h
@@ -408,6 +408,10 @@ extern int getpeereid(int sock, uid_t *uid, gid_t *gid);
 extern int     isinf(double x);
 #endif
 
+#ifndef HAVE_MKDTEMP
+extern char *mkdtemp(char *path);
+#endif
+
 #ifndef HAVE_RINT
 extern double rint(double x);
 #endif
@@ -475,7 +479,4 @@ extern int  pg_check_dir(const char *dir);
 /* port/pgmkdirp.c */
 extern int     pg_mkdir_p(char *path, int omode);
 
-/* port/mkdtemp.c */
-extern char *mkdtemp(char *path);
-
 #endif   /* PG_PORT_H */