EJAB-624: fixes mod_muc_room:is_visitor/2 to use get_role not get_affiliation

SVN Revision: 1534

diff --git a/ChangeLog b/ChangeLog
index 70cf385e10b67aa941007302a677dd7b9c9f848f..1da0b991d3011c02ed4fa5c37750c7b693b79fb8 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-08-24  Geoff Cant  <gcant@process-one.net>
+
+       * src/mod_mud/mod_muc_room.erl: is_visitor/2 fix - use get_role
+       not get_affiliation
+
 2008-08-22  Badlop  <badlop@process-one.net>
 
        * src/ejabberd_router.erl: Fix call to mnesia match_object

diff --git a/src/mod_muc/mod_muc_room.erl b/src/mod_muc/mod_muc_room.erl
index bc2735a831cebb646689f6d8f5195f87979173ff..16268196f268dbbfad241c23c9432c0c26fd239f 100644 (file)
--- a/src/mod_muc/mod_muc_room.erl
+++ b/src/mod_muc/mod_muc_room.erl
@@ -1265,15 +1265,7 @@ get_default_role(Affiliation, StateData) ->
     end.
 
 is_visitor(Jid, StateData) ->
-    case get_affiliation(Jid, StateData) of
-        none ->
-            case get_default_role(none, StateData) of
-                visitor -> true;
-                _ -> false
-            end;
-        visitor -> true;
-        _ -> false
-    end.
+    get_role(Jid, StateData) =:= visitor.
 
 get_max_users(StateData) ->
     MaxUsers = (StateData#state.config)#config.max_users,